From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joerg Roedel Subject: Re: [PATCH v2] iommu: OMAP: device detach on domain destroy Date: Thu, 19 Apr 2012 15:09:54 +0200 Message-ID: <20120419130954.GD2428@amd.com> References: <1334772581-32015-1-git-send-email-omar.luna@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Return-path: Received: from ch1ehsobe006.messaging.microsoft.com ([216.32.181.186]:3323 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752963Ab2DSNKC (ORCPT ); Thu, 19 Apr 2012 09:10:02 -0400 Content-Disposition: inline In-Reply-To: <1334772581-32015-1-git-send-email-omar.luna@linaro.org> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Omar Ramirez Luna Cc: Ohad Ben-Cohen , Tony Lindgren , Laurent Pinchart , iommu@lists.linux-foundation.org, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, patches@linaro.org, linaro-dev@lists.linaro.org On Wed, Apr 18, 2012 at 01:09:41PM -0500, Omar Ramirez Luna wrote: > 'domain_destroy with devices attached' case isn't yet handled, instead > code assumes that the device was already detached. > > If the domain is destroyed the hardware still has access to invalid > pointers to its page table and internal iommu object. In order to > detach the users we need to track devices using the iommu, current > use cases only have one user of iommu per instance. When required > this can evolve to a list with the devices using the iommu_dev. > > Reported-by: Joerg Roedel > Reviewed-by: Ohad Ben-Cohen > Signed-off-by: Omar Ramirez Luna > --- > > v2: rebased onto v3.4-rc2 Applied, thanks. -- AMD Operating System Research Center Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach General Managers: Alberto Bozzo Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632