Re: [PATCH] tty: omap-serial: Keep the wakeup mechanism enabled by default

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Thu, 19 Apr 2012 20:00:12 +0530
"Raja, Govindraj" <govindraj.raja@ti.com> wrote:

> On Thu, Apr 19, 2012 at 12:38 AM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
> >> The point is that wakeups should be enabled whenever driver is in use,
> >> and disabled when the driver is not in use.
> >
> >
> > Which is the tty_port methods for initialisation and shutdown, which are
> > mutex protected against each other and hang up.
> >
> > Not sure how the uart layer glue exposes that.
> 
> Is it okay to read the port flags to identify the port state in
> driver whether the serial port shutdown ops is called from
> port_suspend or due to port closure.
> 
> Since port_shutdown gets called even from uart_suspend_port

That sounds like someone needs to fix the uart code to avoid muddling up
suspend/resume/open/close then, or at least pass the needed information
down.

Don't rely on port->flags ideally, they may well go away in part as they
cease to be needed by the lock changes.

Alan