From: Felipe Balbi <balbi@ti.com>
To: Balaji T K <balajitk@ti.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] arm: omap4: hsmmc: check for null pointer
Date: Mon, 23 Apr 2012 17:43:51 +0300 [thread overview]
Message-ID: <20120423144348.GF26302@arwen.pp.htv.fi> (raw)
In-Reply-To: <1335192067-3666-1-git-send-email-balajitk@ti.com>
[-- Attachment #1: Type: text/plain, Size: 585 bytes --]
Hi,
On Mon, Apr 23, 2012 at 08:11:07PM +0530, Balaji T K wrote:
> +int __init omap4_twl6030_hsmmc_init(struct omap2_hsmmc_info *controllers)
> +{
> + struct omap2_hsmmc_info *c;
> +
> + omap_hsmmc_init(controllers);
> + for (c = controllers; c->mmc; c++) {
> + /* pdev can be null if CONFIG_MMC_OMAP_HS is not set */
> + if (!c->pdev)
> + continue;
> + omap4_twl6030_hsmmc_set_late_init(&c->pdev->dev);
> + }
> +
> + return 0;
> +}
why are you even calling this if CONFIG_MMC_OMAP_HS isn't set ? Just
stub it out if you don't have mmc support.
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-04-23 14:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 14:41 [PATCH v2] arm: omap4: hsmmc: check for null pointer Balaji T K
2012-04-23 14:43 ` Felipe Balbi [this message]
2012-04-25 11:54 ` T Krishnamoorthy, Balaji
2012-04-25 11:57 ` [PATCH v3] " Balaji T K
2012-05-08 23:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120423144348.GF26302@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=balajitk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox