From mboxrd@z Thu Jan 1 00:00:00 1970 From: Russell King - ARM Linux Subject: Re: [PATCH 06/12] mmc: omap_hsmmc: remove private DMA API implementation Date: Tue, 24 Apr 2012 23:05:30 +0100 Message-ID: <20120424220530.GA6290@n2100.arm.linux.org.uk> References: <20120423160409.GE24299@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from caramon.arm.linux.org.uk ([78.32.30.218]:44023 "EHLO caramon.arm.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757339Ab2DXWFm (ORCPT ); Tue, 24 Apr 2012 18:05:42 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Grazvydas Ignotas Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, linux-mmc@vger.kernel.org, Chris Ball On Wed, Apr 25, 2012 at 12:51:09AM +0300, Grazvydas Ignotas wrote: > On Mon, Apr 23, 2012 at 7:06 PM, Russell King > wrote: > > Remove the private DMA API implementation from omap_hsmmc, making it > > use entirely the DMA engine API. > > > > Signed-off-by: Russell King > > Since the driver becomes useless without DMA_ENGINE, we probably want > a 'depends on'? I think it's possible to use tweak this to use PIO should DMA_ENGINE not be available - though first we need to sort out all the filter functions and how we select the DMA channels. That's pretty much an open question (which was brought up in my original set of patches) and remains to these ones. How we did this with the AMBA Primecell drivers was to pass in the filter function and filter argument from platform code, allowing the primecell drivers to be used with any DMA engine. That doesn't work with DT though... At the moment, I don't have an answer for this, because of the DT implications here. So, the issue is rather stuck, and as a result I'm just sticking the "extern" declarations for the filter function into drivers that have been converted.