From: Pavel Machek <pavel@ucw.cz>
To: Aaro Koskinen <aaro.koskinen@nokia.com>
Cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH] arm: omap: add minimal support for Nokia RM-696
Date: Tue, 1 May 2012 12:48:02 +0200 [thread overview]
Message-ID: <20120501104801.GA23559@elf.ucw.cz> (raw)
In-Reply-To: <1330967337-9634-1-git-send-email-aaro.koskinen@nokia.com>
Hi!
> Add minimal support for Nokia RM-696 board.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
> ---
>
> The patch is based & boot-tested with 3.3-rc6.
>
>
> arch/arm/mach-omap2/Kconfig | 3 ++-
> arch/arm/mach-omap2/board-rm680.c | 14 +++++++++++++-
> arch/arm/plat-omap/include/plat/uncompress.h | 1 +
> 3 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
> index e20c8ab..b740c2e 100644
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -245,10 +245,11 @@ config MACH_NOKIA_N8X0
> select MACH_NOKIA_N810_WIMAX
>
> config MACH_NOKIA_RM680
> - bool "Nokia RM-680 board"
> + bool "Nokia RM-680/696 board"
> depends on ARCH_OMAP3
> default y
> select OMAP_PACKAGE_CBB
> + select MACH_NOKIA_RM696
>
AFAICT, this is nokia N9. At least help text should state that...
> config MACH_NOKIA_RX51
> bool "Nokia RX-51 board"
> diff --git a/arch/arm/mach-omap2/board-rm680.c b/arch/arm/mach-omap2/board-rm680.c
> index 8678b38..094473e 100644
> --- a/arch/arm/mach-omap2/board-rm680.c
> +++ b/arch/arm/mach-omap2/board-rm680.c
> @@ -1,5 +1,5 @@
> /*
> - * Board support file for Nokia RM-680.
> + * Board support file for Nokia RM-680/696.
> *
And a comment.
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2012-05-01 10:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 17:08 [PATCH] arm: omap: add minimal support for Nokia RM-696 Aaro Koskinen
2012-03-05 18:38 ` Tony Lindgren
2012-05-01 10:48 ` Pavel Machek [this message]
2012-05-04 18:11 ` Tony Lindgren
2012-10-17 18:33 ` [PATCH] Nokia N9/N900/N950 -- mention product names Pavel Machek
2012-10-17 19:25 ` Aaro Koskinen
2012-10-17 21:03 ` Pavel Machek
2012-10-17 21:21 ` Aaro Koskinen
2012-10-19 17:02 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120501104801.GA23559@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=aaro.koskinen@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).