public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] OMAP4: panda: add statics to remove warnings
Date: Fri, 4 May 2012 12:29:03 -0700	[thread overview]
Message-ID: <20120504192903.GQ5613@atomide.com> (raw)
In-Reply-To: <1335356951.2799.5.camel@deskari>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [120425 05:32]:
> On Tue, 2012-04-24 at 10:16 -0700, Tony Lindgren wrote:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [120423 00:43]:
> > > Add statics to board-omap4-panda.c's internal functions and data
> > > structures to remove warnings.
> > 
> > Care to update with the warnings produced?
> 
> Ah, sure. Updated patch below:
> 
> From e96ddeb7d783d48a15a32f8ef5a7bae3089f66b9 Mon Sep 17 00:00:00 2001
> From: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Date: Wed, 28 Mar 2012 11:38:58 +0300
> Subject: [PATCH] OMAP4: panda: add statics to remove warnings
> 
> Add statics to board-omap4-panda.c's internal functions and data
> structures to remove sparse warnings:
> 
> arch/arm/mach-omap2/board-omap4panda.c:234:29: warning: symbol
> 'omap_panda_wlan_data' was not declared. Should it be static?
> arch/arm/mach-omap2/board-omap4panda.c:441:24: warning: symbol
> 'omap4_panda_dvi_device' was not declared. Should it be static?
> arch/arm/mach-omap2/board-omap4panda.c:451:12: warning: symbol
> 'omap4_panda_dvi_init' was not declared. Should it be static?
> arch/arm/mach-omap2/board-omap4panda.c:512:13: warning: symbol
> 'omap4_panda_display_init' was not declared. Should it be static?

Thanks adding to fixes-non-critical.

Tony

  reply	other threads:[~2012-05-04 19:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-23  7:39 [PATCH] OMAP4: panda: add statics to remove warnings Tomi Valkeinen
2012-04-24 17:16 ` Tony Lindgren
2012-04-25 12:29   ` Tomi Valkeinen
2012-05-04 19:29     ` Tony Lindgren [this message]
2012-05-11 12:55       ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120504192903.GQ5613@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox