Re: [PATCH 5/9] tty/serial/omap: console can only be built-in

Tony Lindgren
2012-03-23T18:33:39Z

* mathieu.poirier@linaro.org <mathieu.poirier@linaro.org> [120323 10:16]:
> From: Arnd Bergmann <arnd@arndb.de>
>
> When the omap serial driver is built as a module, we must
> not allow the console driver to be selected, because consoles
> can not be loadable modules.

Looks valid to me, this should get posted and merged via
linux-serial@vger.kernel.org.

Tony

>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Acked-by: Govindraj.R <govindraj.raja@ti.com>
> ---
> drivers/tty/serial/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 2de9924..bcf7e24 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1041,7 +1041,7 @@ config SERIAL_OMAP
>
> config SERIAL_OMAP_CONSOLE
> bool "Console on OMAP serial port"
> - depends on SERIAL_OMAP
> + depends on SERIAL_OMAP=y
> select SERIAL_CORE_CONSOLE
> help
> Select this option if you would like to use omap serial port as
> --
> 1.7.5.4
>