From: Tony Lindgren <tony@atomide.com>
To: Russ Dill <Russ.Dill@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] [OMAP] Mark Beagleboard-xM MMC bus as 4-bit
Date: Mon, 7 May 2012 13:31:40 -0700 [thread overview]
Message-ID: <20120507203139.GL5088@atomide.com> (raw)
In-Reply-To: <1336420577-2578-1-git-send-email-Russ.Dill@ti.com>
* Russ Dill <Russ.Dill@ti.com> [120507 13:00]:
> On Beagleboard-xM (all revisions) only MMC1_DAT0-MMC1_DAT3 are wired up.
> Tested on Beagleboard-xM Rev C1 and Beagleboard Rev B4.
>
> Signed-off-by: Russ Dill <Russ.Dill@ti.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 7be8d65..3b9647a 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -523,6 +523,10 @@ static void __init omap3_beagle_init(void)
>
> if (beagle_config.mmc1_gpio_wp != -EINVAL)
> omap_mux_init_gpio(beagle_config.mmc1_gpio_wp, OMAP_PIN_INPUT);
> +
> + /* All xM versions have 4-bit MMC bus */
> + if (cpu_is_omap3630())
> + mmc[0].caps &= ~MMC_CAP_8_BIT_DATA;
> omap_hsmmc_init(mmc);
>
> omap3_beagle_i2c_init();
This would be better done in omap3_beagle_init_rev as various other
things are already initialized there based on the revision.
Tony
next prev parent reply other threads:[~2012-05-07 20:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 19:56 [PATCH] [OMAP] Mark Beagleboard-xM MMC bus as 4-bit Russ Dill
2012-05-07 20:31 ` Tony Lindgren [this message]
2012-05-08 2:24 ` [PATCH v2] " Russ Dill
2012-05-09 0:14 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120507203139.GL5088@atomide.com \
--to=tony@atomide.com \
--cc=Russ.Dill@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox