From: Tony Lindgren <tony@atomide.com>
To: Vaibhav Hiremath <hvaibhav@ti.com>
Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Kevin Hilman <khilman@ti.com>, Paul Walmsley <paul@pwsan.com>
Subject: Re: [PATCH] ARM: OMAP2+: am33xx: Make am33xx as a separate class
Date: Tue, 8 May 2012 13:08:34 -0700 [thread overview]
Message-ID: <20120508200833.GD5088@atomide.com> (raw)
In-Reply-To: <1336490630-7272-1-git-send-email-hvaibhav@ti.com>
* Vaibhav Hiremath <hvaibhav@ti.com> [120508 08:32]:
> --- a/arch/arm/mach-omap2/Kconfig
> +++ b/arch/arm/mach-omap2/Kconfig
> @@ -123,8 +123,11 @@ config SOC_OMAPTI81XX
>
> config SOC_OMAPAM33XX
> bool "AM33XX support"
> - depends on ARCH_OMAP3
> + depends on ARCH_OMAP2PLUS
This is not needed, it's inside if ARCH_OMAP2PLUS block.
> --- a/arch/arm/mach-omap2/Makefile
> +++ b/arch/arm/mach-omap2/Makefile
> @@ -16,6 +16,7 @@ secure-common = omap-smc.o omap-secure.o
> obj-$(CONFIG_ARCH_OMAP2) += $(omap-2-3-common) $(hwmod-common)
> obj-$(CONFIG_ARCH_OMAP3) += $(omap-2-3-common) $(hwmod-common) $(secure-common)
> obj-$(CONFIG_ARCH_OMAP4) += prm44xx.o $(hwmod-common) $(secure-common)
> +obj-$(CONFIG_SOC_OMAPAM33XX) += irq.o $(hwmod-common)
>
> ifneq ($(CONFIG_SND_OMAP_SOC_MCBSP),)
> obj-y += mcbsp.o
> @@ -93,6 +94,7 @@ obj-$(CONFIG_ARCH_OMAP4) += prcm.o cm2xxx_3xxx.o cminst44xx.o \
> cm44xx.o prcm_mpu44xx.o \
> prminst44xx.o vc44xx_data.o \
> vp44xx_data.o prm44xx.o
> +obj-$(CONFIG_SOC_OMAPAM33XX) += prcm.o
>
> # OMAP voltage domains
> voltagedomain-common := voltage.o vc.o vp.o
> @@ -102,6 +104,7 @@ obj-$(CONFIG_ARCH_OMAP3) += $(voltagedomain-common) \
> voltagedomains3xxx_data.o
> obj-$(CONFIG_ARCH_OMAP4) += $(voltagedomain-common) \
> voltagedomains44xx_data.o
> +obj-$(CONFIG_SOC_OMAPAM33XX) += $(voltagedomain-common)
>
> # OMAP powerdomain framework
> powerdomain-common += powerdomain.o powerdomain-common.o
> @@ -116,6 +119,7 @@ obj-$(CONFIG_ARCH_OMAP3) += $(powerdomain-common) \
> obj-$(CONFIG_ARCH_OMAP4) += $(powerdomain-common) \
> powerdomain44xx.o \
> powerdomains44xx_data.o
> +obj-$(CONFIG_SOC_OMAPAM33XX) += $(powerdomain-common)
>
> # PRCM clockdomain control
> clockdomain-common += clockdomain.o \
> @@ -132,6 +136,7 @@ obj-$(CONFIG_ARCH_OMAP3) += $(clockdomain-common) \
> obj-$(CONFIG_ARCH_OMAP4) += $(clockdomain-common) \
> clockdomain44xx.o \
> clockdomains44xx_data.o
> +obj-$(CONFIG_SOC_OMAPAM33XX) += $(clockdomain-common)
>
> # Clock framework
> obj-$(CONFIG_ARCH_OMAP2) += $(clock-common) clock2xxx.o \
> @@ -149,6 +154,7 @@ obj-$(CONFIG_ARCH_OMAP3) += $(clock-common) clock3xxx.o \
> clkt_iclk.o
> obj-$(CONFIG_ARCH_OMAP4) += $(clock-common) clock44xx_data.o \
> dpll3xxx.o dpll44xx.o
> +obj-$(CONFIG_SOC_OMAPAM33XX) += $(clock-common) dpll3xxx.o
>
> # OMAP2 clock rate set data (old "OPP" data)
> obj-$(CONFIG_SOC_OMAP2420) += opp2420_data.o
Can you please rebase this on what's now in the cleanup branch at commit
382ae00105d9989a821f458084e0428bce10b969? That should simplify the Makefile
changes a bit.
Other than that looks good to me.
Tony
next prev parent reply other threads:[~2012-05-08 20:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 15:23 [PATCH] ARM: OMAP2+: am33xx: Make am33xx as a separate class Vaibhav Hiremath
2012-05-08 20:08 ` Tony Lindgren [this message]
2012-05-09 9:08 ` Hiremath, Vaibhav
2012-05-08 21:57 ` Kevin Hilman
2012-05-08 21:58 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120508200833.GD5088@atomide.com \
--to=tony@atomide.com \
--cc=hvaibhav@ti.com \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox