* [PATCH v2] OMAP: igep0020: fix smsc911x dummy regulator id
@ 2012-05-09 9:27 Enrico Butera
2012-05-09 15:23 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Enrico Butera @ 2012-05-09 9:27 UTC (permalink / raw)
To: linux-omap; +Cc: Tony Lindgren, Olof Johansson, Enrico Butera
From: Enrico Butera <ebutera@users.berlios.de>
id 0 is already used and causes errors at boot:
WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
sysfs: cannot create duplicate filename '/devices/platform/reg-fixed-voltage.0'
Fix it by using the next available one (id=1).
Signed-off-by: Enrico Butera <ebutera@users.berlios.de>
---
arch/arm/mach-omap2/board-igep0020.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
index 930c0d3..740cee9 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -641,7 +641,7 @@ static struct regulator_consumer_supply dummy_supplies[] = {
static void __init igep_init(void)
{
- regulator_register_fixed(0, dummy_supplies, ARRAY_SIZE(dummy_supplies));
+ regulator_register_fixed(1, dummy_supplies, ARRAY_SIZE(dummy_supplies));
omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
/* Get IGEP2 hardware revision */
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] OMAP: igep0020: fix smsc911x dummy regulator id
2012-05-09 9:27 [PATCH v2] OMAP: igep0020: fix smsc911x dummy regulator id Enrico Butera
@ 2012-05-09 15:23 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-05-09 15:23 UTC (permalink / raw)
To: Enrico Butera; +Cc: linux-omap, Olof Johansson, Enrico Butera
* Enrico Butera <ebutera@users.sourceforge.net> [120509 02:32]:
> From: Enrico Butera <ebutera@users.berlios.de>
>
> id 0 is already used and causes errors at boot:
>
> WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
> sysfs: cannot create duplicate filename '/devices/platform/reg-fixed-voltage.0'
>
> Fix it by using the next available one (id=1).
Thanks adding into fixes with updated comments for the regression,
updated patch below.
Tony
From: Enrico Butera <ebutera@users.berlios.de>
Date: Wed, 9 May 2012 11:27:59 +0200
Subject: [PATCH] ARM: OMAP: igep0020: fix smsc911x dummy regulator id
id 0 is already used and causes errors at boot:
WARNING: at fs/sysfs/dir.c:508 sysfs_add_one+0x9c/0xac()
sysfs: cannot create duplicate filename '/devices/platform/reg-fixed-voltage.0'
Fix it by using the next available one (id=1).
This was caused by 5b3689f4 (ARM: OMAP2+: smsc911x: Add fixed
board regulators) that did not account for some regulators
already being used.
Signed-off-by: Enrico Butera <ebutera@users.berlios.de>
[tony@atomide.com: updated comments for regression causing commit]
Signed-off-by: Tony Lindgren <tony@atomide.com>
diff --git a/arch/arm/mach-omap2/board-igep0020.c b/arch/arm/mach-omap2/board-igep0020.c
index 930c0d3..740cee9 100644
--- a/arch/arm/mach-omap2/board-igep0020.c
+++ b/arch/arm/mach-omap2/board-igep0020.c
@@ -641,7 +641,7 @@ static struct regulator_consumer_supply dummy_supplies[] = {
static void __init igep_init(void)
{
- regulator_register_fixed(0, dummy_supplies, ARRAY_SIZE(dummy_supplies));
+ regulator_register_fixed(1, dummy_supplies, ARRAY_SIZE(dummy_supplies));
omap3_mux_init(board_mux, OMAP_PACKAGE_CBB);
/* Get IGEP2 hardware revision */
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-09 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-09 9:27 [PATCH v2] OMAP: igep0020: fix smsc911x dummy regulator id Enrico Butera
2012-05-09 15:23 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox