Re: [PATCH 3/3] ARM: OMAP: AM35xx: fix UART4 softreset

Paul Walmsley
2012-05-11T10:36:31Z

On Fri, 11 May 2012, Cousson, Benoit wrote:

> But they are not separately gated for OMAP4 either. This is the modulemode
> trick that make us think that, but it just means that the PRCM should ensure
> that this clock is needed when at least one UART modulemode is enabled. In
> fact the SPI modules are using the same clock.
>
> The modulemode is used to do some reference counting, but the gating is done
> globally. It was the same with the FCK_EN and ICK_EN in OMAP2&3.
>
> The PRCM spec show only one global gating between FUNC_48M_FCLK and
> PER_48M_GFCLK. All the modules are sharing the exact same clock.

Well, on OMAP3 and AM3517, they do not all share the same clock. If you
look at the 34xx TRM vZU Table 17-11 "UART Clocks", you can see that the
UART1 and 2 functional clocks are sourced from clocks managed by the CORE
clockdomain, while UART3 is sourced from clocks managed by the PER
clockdomain. This is also expressed in our OMAP3 clock tree.

I realize this is slightly tangential to your point. As to where the
clock gating nodes are actually located on a given piece of silicon,
unfortunately I have no way of confirming that, aside from power
measurement. You might be correct about what's going on with the AM3517
but it would be nice to get some confirmation from the AM35xx PRCM
engineer(s). At this point one of two possibilities seem likely: either
CM_FCLKEN1_CORE.EN_UART4 does nothing, or CM_FCLKEN1_CORE.EN_UART4 is
necessary but not sufficient to get the UART4 to work. If
CM_FCLKEN1_CORE.EN_UART4 does not actually do anything then we need to
remove it from the kernel and ideally file a documentation bug to get it
removed from the TRM. On the other hand, if we do have to enable
CM_FCLKEN1_CORE.EN_UART4 to deassert the IdleAck to UART4, but the PRCM
usecounting is broken, then I guess we'll need to add a workaround to the
hwmod code to essentially support multiple "main clocks".

- Paul