* [PATCH] OMAP: Beagle: fix DVI GPIO request
@ 2012-05-21 9:41 Tomi Valkeinen
2012-05-21 9:41 ` Tomi Valkeinen
2012-05-21 15:52 ` Russ Dill
0 siblings, 2 replies; 12+ messages in thread
From: Tomi Valkeinen @ 2012-05-21 9:41 UTC (permalink / raw)
To: tony; +Cc: linux-omap, Tomi Valkeinen
Tony,
There is a bug in the for-l-o-3.5 branch I sent earlier, causing the DVI driver
to fail to request the power-down GPIO. This patch fixes it.
Tomi Valkeinen (1):
OMAP: Beagle: fix DVI GPIO request
arch/arm/mach-omap2/board-omap3beagle.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
1.7.9.5
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 9:41 [PATCH] OMAP: Beagle: fix DVI GPIO request Tomi Valkeinen
@ 2012-05-21 9:41 ` Tomi Valkeinen
2012-05-21 10:59 ` Koen Kooi
2012-05-21 12:56 ` Tomi Valkeinen
2012-05-21 15:52 ` Russ Dill
1 sibling, 2 replies; 12+ messages in thread
From: Tomi Valkeinen @ 2012-05-21 9:41 UTC (permalink / raw)
To: tony; +Cc: linux-omap, Tomi Valkeinen
Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
remove custom PD GPIO handling for DVI output") moved TFP410 chip's
powerdown-gpio handling from the board files to the tfp410 driver. One
gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
the Beagle board file. This causes the tfp410 driver to fail to request
the gpio on Beagle, causing the driver to fail and thus the DVI output
doesn't work.
This patch removes the gpio_request_one() from the board file.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
arch/arm/mach-omap2/board-omap3beagle.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 8ede8d2..72ad1f6 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
omap_sdrc_init(mt46h32m32lf6_sdrc_params,
mt46h32m32lf6_sdrc_params);
+ /* DVI power down GPIO */
omap_mux_init_gpio(170, OMAP_PIN_INPUT);
- /* REVISIT leave DVI powered down until it's needed ... */
- gpio_request_one(170, GPIOF_OUT_INIT_HIGH, "DVI_nPD");
usb_musb_init(NULL);
usbhs_init(&usbhs_bdata);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 9:41 ` Tomi Valkeinen
@ 2012-05-21 10:59 ` Koen Kooi
2012-05-21 11:12 ` Tomi Valkeinen
2012-05-21 12:56 ` Tomi Valkeinen
1 sibling, 1 reply; 12+ messages in thread
From: Koen Kooi @ 2012-05-21 10:59 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: tony, linux-omap
Op 21 mei 2012, om 11:41 heeft Tomi Valkeinen het volgende geschreven:
> Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
> remove custom PD GPIO handling for DVI output") moved TFP410 chip's
> powerdown-gpio handling from the board files to the tfp410 driver. One
> gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
> the Beagle board file. This causes the tfp410 driver to fail to request
> the gpio on Beagle, causing the driver to fail and thus the DVI output
> doesn't work.
>
> This patch removes the gpio_request_one() from the board file.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> ---
> arch/arm/mach-omap2/board-omap3beagle.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> index 8ede8d2..72ad1f6 100644
> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> @@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
> omap_sdrc_init(mt46h32m32lf6_sdrc_params,
> mt46h32m32lf6_sdrc_params);
>
> + /* DVI power down GPIO */
> omap_mux_init_gpio(170, OMAP_PIN_INPUT);
Wouldn't it be an output rather than an input?
regards,
Koen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 10:59 ` Koen Kooi
@ 2012-05-21 11:12 ` Tomi Valkeinen
2012-05-21 11:28 ` Koen Kooi
0 siblings, 1 reply; 12+ messages in thread
From: Tomi Valkeinen @ 2012-05-21 11:12 UTC (permalink / raw)
To: Koen Kooi; +Cc: tony, linux-omap
[-- Attachment #1: Type: text/plain, Size: 1688 bytes --]
On Mon, 2012-05-21 at 12:59 +0200, Koen Kooi wrote:
> Op 21 mei 2012, om 11:41 heeft Tomi Valkeinen het volgende geschreven:
>
> > Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
> > remove custom PD GPIO handling for DVI output") moved TFP410 chip's
> > powerdown-gpio handling from the board files to the tfp410 driver. One
> > gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
> > the Beagle board file. This causes the tfp410 driver to fail to request
> > the gpio on Beagle, causing the driver to fail and thus the DVI output
> > doesn't work.
> >
> > This patch removes the gpio_request_one() from the board file.
> >
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > ---
> > arch/arm/mach-omap2/board-omap3beagle.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> > index 8ede8d2..72ad1f6 100644
> > --- a/arch/arm/mach-omap2/board-omap3beagle.c
> > +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> > @@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
> > omap_sdrc_init(mt46h32m32lf6_sdrc_params,
> > mt46h32m32lf6_sdrc_params);
> >
> > + /* DVI power down GPIO */
> > omap_mux_init_gpio(170, OMAP_PIN_INPUT);
>
> Wouldn't it be an output rather than an input?
Indeed. Note that I didn't change the line above =).
It seems this was changed last December:
- omap_cfg_reg(J25_34XX_GPIO170);
+ omap_mux_init_gpio(170, OMAP_PIN_INPUT);
I wonder if the mux init is even necessary. Shouldn't the bootloader set
the muxes?
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 11:12 ` Tomi Valkeinen
@ 2012-05-21 11:28 ` Koen Kooi
2012-05-21 11:36 ` Tomi Valkeinen
0 siblings, 1 reply; 12+ messages in thread
From: Koen Kooi @ 2012-05-21 11:28 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: tony, linux-omap
Op 21 mei 2012, om 13:12 heeft Tomi Valkeinen het volgende geschreven:
> On Mon, 2012-05-21 at 12:59 +0200, Koen Kooi wrote:
>> Op 21 mei 2012, om 11:41 heeft Tomi Valkeinen het volgende geschreven:
>>
>>> Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
>>> remove custom PD GPIO handling for DVI output") moved TFP410 chip's
>>> powerdown-gpio handling from the board files to the tfp410 driver. One
>>> gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
>>> the Beagle board file. This causes the tfp410 driver to fail to request
>>> the gpio on Beagle, causing the driver to fail and thus the DVI output
>>> doesn't work.
>>>
>>> This patch removes the gpio_request_one() from the board file.
>>>
>>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
>>> ---
>>> arch/arm/mach-omap2/board-omap3beagle.c | 3 +--
>>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>>
>>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
>>> index 8ede8d2..72ad1f6 100644
>>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
>>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
>>> @@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
>>> omap_sdrc_init(mt46h32m32lf6_sdrc_params,
>>> mt46h32m32lf6_sdrc_params);
>>>
>>> + /* DVI power down GPIO */
>>> omap_mux_init_gpio(170, OMAP_PIN_INPUT);
>>
>> Wouldn't it be an output rather than an input?
>
> Indeed. Note that I didn't change the line above =).
>
> It seems this was changed last December:
>
> - omap_cfg_reg(J25_34XX_GPIO170);
> + omap_mux_init_gpio(170, OMAP_PIN_INPUT);
>
> I wonder if the mux init is even necessary. Shouldn't the bootloader set
> the muxes?
It'd rather have the kernel reset the muxes to the proper value to ensure a known state.
regards,
Koen
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 11:28 ` Koen Kooi
@ 2012-05-21 11:36 ` Tomi Valkeinen
2012-05-21 16:11 ` Tony Lindgren
0 siblings, 1 reply; 12+ messages in thread
From: Tomi Valkeinen @ 2012-05-21 11:36 UTC (permalink / raw)
To: Koen Kooi; +Cc: tony, linux-omap
[-- Attachment #1: Type: text/plain, Size: 2361 bytes --]
On Mon, 2012-05-21 at 13:28 +0200, Koen Kooi wrote:
> Op 21 mei 2012, om 13:12 heeft Tomi Valkeinen het volgende geschreven:
>
> > On Mon, 2012-05-21 at 12:59 +0200, Koen Kooi wrote:
> >> Op 21 mei 2012, om 11:41 heeft Tomi Valkeinen het volgende geschreven:
> >>
> >>> Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
> >>> remove custom PD GPIO handling for DVI output") moved TFP410 chip's
> >>> powerdown-gpio handling from the board files to the tfp410 driver. One
> >>> gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
> >>> the Beagle board file. This causes the tfp410 driver to fail to request
> >>> the gpio on Beagle, causing the driver to fail and thus the DVI output
> >>> doesn't work.
> >>>
> >>> This patch removes the gpio_request_one() from the board file.
> >>>
> >>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> >>> ---
> >>> arch/arm/mach-omap2/board-omap3beagle.c | 3 +--
> >>> 1 file changed, 1 insertion(+), 2 deletions(-)
> >>>
> >>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> >>> index 8ede8d2..72ad1f6 100644
> >>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> >>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> >>> @@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
> >>> omap_sdrc_init(mt46h32m32lf6_sdrc_params,
> >>> mt46h32m32lf6_sdrc_params);
> >>>
> >>> + /* DVI power down GPIO */
> >>> omap_mux_init_gpio(170, OMAP_PIN_INPUT);
> >>
> >> Wouldn't it be an output rather than an input?
> >
> > Indeed. Note that I didn't change the line above =).
> >
> > It seems this was changed last December:
> >
> > - omap_cfg_reg(J25_34XX_GPIO170);
> > + omap_mux_init_gpio(170, OMAP_PIN_INPUT);
> >
> > I wonder if the mux init is even necessary. Shouldn't the bootloader set
> > the muxes?
>
> It'd rather have the kernel reset the muxes to the proper value to ensure a known state.
Well, I think all this needs to be handled differently anyway with
device tree. If I've understood correctly the driver using the GPIO
should configure the pin when the driver starts. But if the driver is
not loaded/compiled-in, then it's again up to the bootloader.
Or is there going to be a board specific mux-init with devtree?
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 9:41 ` Tomi Valkeinen
2012-05-21 10:59 ` Koen Kooi
@ 2012-05-21 12:56 ` Tomi Valkeinen
1 sibling, 0 replies; 12+ messages in thread
From: Tomi Valkeinen @ 2012-05-21 12:56 UTC (permalink / raw)
To: tony; +Cc: linux-omap, Koen Kooi
[-- Attachment #1: Type: text/plain, Size: 1772 bytes --]
Here's an updated patch with a fix for the GPIO direction:
From e74be66075d14f7ed55ba3aaa8a166eac6a3e60f Mon Sep 17 00:00:00 2001
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
Date: Mon, 21 May 2012 11:28:57 +0300
Subject: [PATCH] OMAP: Beagle: fix TFP410 powerdown GPIO init
Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
remove custom PD GPIO handling for DVI output") moved TFP410 chip's
powerdown-gpio handling from the board files to the tfp410 driver. One
gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
the Beagle board file. This causes the tfp410 driver to fail to request
the gpio on Beagle, causing the driver to fail and thus the DVI output
doesn't work.
Also the powerdown-gpio is initialized as OMAP_PIN_INPUT, whereas it's
an output.
This patch removes the gpio_request_one() from the board file and
changes the pin to OMAP_PIN_OUTPUT.
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
arch/arm/mach-omap2/board-omap3beagle.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
index 8ede8d2..5066080 100644
--- a/arch/arm/mach-omap2/board-omap3beagle.c
+++ b/arch/arm/mach-omap2/board-omap3beagle.c
@@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
omap_sdrc_init(mt46h32m32lf6_sdrc_params,
mt46h32m32lf6_sdrc_params);
- omap_mux_init_gpio(170, OMAP_PIN_INPUT);
- /* REVISIT leave DVI powered down until it's needed ... */
- gpio_request_one(170, GPIOF_OUT_INIT_HIGH, "DVI_nPD");
+ /* TFP410 power down GPIO */
+ omap_mux_init_gpio(170, OMAP_PIN_OUTPUT);
usb_musb_init(NULL);
usbhs_init(&usbhs_bdata);
--
1.7.9.5
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 9:41 [PATCH] OMAP: Beagle: fix DVI GPIO request Tomi Valkeinen
2012-05-21 9:41 ` Tomi Valkeinen
@ 2012-05-21 15:52 ` Russ Dill
2012-05-21 15:55 ` Tomi Valkeinen
1 sibling, 1 reply; 12+ messages in thread
From: Russ Dill @ 2012-05-21 15:52 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: tony, linux-omap
The correct patch for this was sent earlier:
http://www.spinics.net/lists/linux-omap/msg70042.html
"[PATCH v4] ARM: OMAP: Cleanup Beagleboard DVI reset gpio"
On Mon, May 21, 2012 at 2:41 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> Tony,
>
> There is a bug in the for-l-o-3.5 branch I sent earlier, causing the DVI driver
> to fail to request the power-down GPIO. This patch fixes it.
The correct patch for this was sent earlier:
http://www.spinics.net/lists/linux-omap/msg70042.html
"[PATCH v4] ARM: OMAP: Cleanup Beagleboard DVI reset gpio"
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 15:52 ` Russ Dill
@ 2012-05-21 15:55 ` Tomi Valkeinen
2012-05-21 16:01 ` Russ Dill
0 siblings, 1 reply; 12+ messages in thread
From: Tomi Valkeinen @ 2012-05-21 15:55 UTC (permalink / raw)
To: Russ Dill; +Cc: tony, linux-omap
[-- Attachment #1: Type: text/plain, Size: 763 bytes --]
On Mon, 2012-05-21 at 08:52 -0700, Russ Dill wrote:
> The correct patch for this was sent earlier:
>
> http://www.spinics.net/lists/linux-omap/msg70042.html
> "[PATCH v4] ARM: OMAP: Cleanup Beagleboard DVI reset gpio"
>
> On Mon, May 21, 2012 at 2:41 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > Tony,
> >
> > There is a bug in the for-l-o-3.5 branch I sent earlier, causing the DVI driver
> > to fail to request the power-down GPIO. This patch fixes it.
>
>
> The correct patch for this was sent earlier:
>
> http://www.spinics.net/lists/linux-omap/msg70042.html
> "[PATCH v4] ARM: OMAP: Cleanup Beagleboard DVI reset gpio"
Right, and I was cc'd. Sorry, I somehow totally forgot about that =).
So ignore my patch.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 15:55 ` Tomi Valkeinen
@ 2012-05-21 16:01 ` Russ Dill
2012-05-21 16:02 ` Tomi Valkeinen
0 siblings, 1 reply; 12+ messages in thread
From: Russ Dill @ 2012-05-21 16:01 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: tony, linux-omap
On Mon, May 21, 2012 at 8:55 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> On Mon, 2012-05-21 at 08:52 -0700, Russ Dill wrote:
>> The correct patch for this was sent earlier:
>>
>> http://www.spinics.net/lists/linux-omap/msg70042.html
>> "[PATCH v4] ARM: OMAP: Cleanup Beagleboard DVI reset gpio"
>>
>> On Mon, May 21, 2012 at 2:41 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
>> > Tony,
>> >
>> > There is a bug in the for-l-o-3.5 branch I sent earlier, causing the DVI driver
>> > to fail to request the power-down GPIO. This patch fixes it.
>>
>>
>> The correct patch for this was sent earlier:
>>
>> http://www.spinics.net/lists/linux-omap/msg70042.html
>> "[PATCH v4] ARM: OMAP: Cleanup Beagleboard DVI reset gpio"
>
> Right, and I was cc'd. Sorry, I somehow totally forgot about that =).
>
> So ignore my patch.
Did you also get the 'OMAPDSS: TFP410: use gpio_set_value_cansleep'?
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 16:01 ` Russ Dill
@ 2012-05-21 16:02 ` Tomi Valkeinen
0 siblings, 0 replies; 12+ messages in thread
From: Tomi Valkeinen @ 2012-05-21 16:02 UTC (permalink / raw)
To: Russ Dill; +Cc: tony, linux-omap
[-- Attachment #1: Type: text/plain, Size: 1084 bytes --]
On Mon, 2012-05-21 at 09:01 -0700, Russ Dill wrote:
> On Mon, May 21, 2012 at 8:55 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> > On Mon, 2012-05-21 at 08:52 -0700, Russ Dill wrote:
> >> The correct patch for this was sent earlier:
> >>
> >> http://www.spinics.net/lists/linux-omap/msg70042.html
> >> "[PATCH v4] ARM: OMAP: Cleanup Beagleboard DVI reset gpio"
> >>
> >> On Mon, May 21, 2012 at 2:41 AM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote:
> >> > Tony,
> >> >
> >> > There is a bug in the for-l-o-3.5 branch I sent earlier, causing the DVI driver
> >> > to fail to request the power-down GPIO. This patch fixes it.
> >>
> >>
> >> The correct patch for this was sent earlier:
> >>
> >> http://www.spinics.net/lists/linux-omap/msg70042.html
> >> "[PATCH v4] ARM: OMAP: Cleanup Beagleboard DVI reset gpio"
> >
> > Right, and I was cc'd. Sorry, I somehow totally forgot about that =).
> >
> > So ignore my patch.
>
> Did you also get the 'OMAPDSS: TFP410: use gpio_set_value_cansleep'?
Yes, that has been applied into omapdss tree.
Tomi
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] OMAP: Beagle: fix DVI GPIO request
2012-05-21 11:36 ` Tomi Valkeinen
@ 2012-05-21 16:11 ` Tony Lindgren
0 siblings, 0 replies; 12+ messages in thread
From: Tony Lindgren @ 2012-05-21 16:11 UTC (permalink / raw)
To: Tomi Valkeinen; +Cc: Koen Kooi, linux-omap
* Tomi Valkeinen <tomi.valkeinen@ti.com> [120521 04:40]:
> On Mon, 2012-05-21 at 13:28 +0200, Koen Kooi wrote:
> > Op 21 mei 2012, om 13:12 heeft Tomi Valkeinen het volgende geschreven:
> >
> > > On Mon, 2012-05-21 at 12:59 +0200, Koen Kooi wrote:
> > >> Op 21 mei 2012, om 11:41 heeft Tomi Valkeinen het volgende geschreven:
> > >>
> > >>> Commit e813a55eb9c9bc6c8039fb16332cf43402125b30 ("OMAP: board-files:
> > >>> remove custom PD GPIO handling for DVI output") moved TFP410 chip's
> > >>> powerdown-gpio handling from the board files to the tfp410 driver. One
> > >>> gpio_request_one(powerdown-gpio, ...) was mistakenly left unremoved in
> > >>> the Beagle board file. This causes the tfp410 driver to fail to request
> > >>> the gpio on Beagle, causing the driver to fail and thus the DVI output
> > >>> doesn't work.
> > >>>
> > >>> This patch removes the gpio_request_one() from the board file.
> > >>>
> > >>> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> > >>> ---
> > >>> arch/arm/mach-omap2/board-omap3beagle.c | 3 +--
> > >>> 1 file changed, 1 insertion(+), 2 deletions(-)
> > >>>
> > >>> diff --git a/arch/arm/mach-omap2/board-omap3beagle.c b/arch/arm/mach-omap2/board-omap3beagle.c
> > >>> index 8ede8d2..72ad1f6 100644
> > >>> --- a/arch/arm/mach-omap2/board-omap3beagle.c
> > >>> +++ b/arch/arm/mach-omap2/board-omap3beagle.c
> > >>> @@ -510,9 +510,8 @@ static void __init omap3_beagle_init(void)
> > >>> omap_sdrc_init(mt46h32m32lf6_sdrc_params,
> > >>> mt46h32m32lf6_sdrc_params);
> > >>>
> > >>> + /* DVI power down GPIO */
> > >>> omap_mux_init_gpio(170, OMAP_PIN_INPUT);
> > >>
> > >> Wouldn't it be an output rather than an input?
> > >
> > > Indeed. Note that I didn't change the line above =).
> > >
> > > It seems this was changed last December:
> > >
> > > - omap_cfg_reg(J25_34XX_GPIO170);
> > > + omap_mux_init_gpio(170, OMAP_PIN_INPUT);
> > >
> > > I wonder if the mux init is even necessary. Shouldn't the bootloader set
> > > the muxes?
> >
> > It'd rather have the kernel reset the muxes to the proper value to ensure a known state.
>
> Well, I think all this needs to be handled differently anyway with
> device tree. If I've understood correctly the driver using the GPIO
> should configure the pin when the driver starts. But if the driver is
> not loaded/compiled-in, then it's again up to the bootloader.
>
> Or is there going to be a board specific mux-init with devtree?
For device tree the mux setting will come from devicetree. Until
that works, it's best to keep the omap_mux_init_gpio() calll.
Regards,
Tony
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2012-05-21 16:11 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-21 9:41 [PATCH] OMAP: Beagle: fix DVI GPIO request Tomi Valkeinen
2012-05-21 9:41 ` Tomi Valkeinen
2012-05-21 10:59 ` Koen Kooi
2012-05-21 11:12 ` Tomi Valkeinen
2012-05-21 11:28 ` Koen Kooi
2012-05-21 11:36 ` Tomi Valkeinen
2012-05-21 16:11 ` Tony Lindgren
2012-05-21 12:56 ` Tomi Valkeinen
2012-05-21 15:52 ` Russ Dill
2012-05-21 15:55 ` Tomi Valkeinen
2012-05-21 16:01 ` Russ Dill
2012-05-21 16:02 ` Tomi Valkeinen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).