From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sebastien Guiriec <s-guiriec@ti.com>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Liam Girdwood <lrg@ti.com>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: omap-mcbsp: Add pm_runtime_get/put functions call for McBSP.
Date: Fri, 1 Jun 2012 21:24:50 +0100 [thread overview]
Message-ID: <20120601202449.GA4258@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <1338581572-11047-1-git-send-email-s-guiriec@ti.com>
[-- Attachment #1: Type: text/plain, Size: 802 bytes --]
On Fri, Jun 01, 2012 at 10:12:52PM +0200, Sebastien Guiriec wrote:
> pm_runtime_get_sync() and put_sync() are not called by McBSP driver.
> This is introducing a problem with PM and Audio Backend due to
> missing get/put for McBSP IP.
They are called by the core. Probably you're just pointing your struct
device at some virtual device instead of the physical device, either
enabling runtime PM for the virtual device (assuming it's a child of the
physical device) or changing the pointer to the physical device (which
might make for better dev_ logging potentially) should resolve the
issue.
> + pm_runtime_put_sync(mcbsp->dev);
No need for this, anyway - just use regular _put(). We don't care if
the device is actually suspended before we return, the PM core can do
that at it's leisure.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2012-06-01 20:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-01 20:12 [PATCH] ASoC: omap-mcbsp: Add pm_runtime_get/put functions call for McBSP Sebastien Guiriec
2012-06-01 20:24 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120601202449.GA4258@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=jarkko.nikula@bitmer.com \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@ti.com \
--cc=peter.ujfalusi@ti.com \
--cc=s-guiriec@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox