* [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2
@ 2012-06-09 14:56 Vaibhav Hiremath
2012-06-11 6:38 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Vaibhav Hiremath @ 2012-06-09 14:56 UTC (permalink / raw)
To: linux-omap; +Cc: tony, linux-arm-kernel, Vaibhav Hiremath
Newly added AM33XX device falls under omap2 class, so
make cpu_class_is_omap2() true for AM33XX
(Add soc_is_am33xx() check).
Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
---
arch/arm/plat-omap/include/plat/cpu.h | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h
index 14f050f..5e36564 100644
--- a/arch/arm/plat-omap/include/plat/cpu.h
+++ b/arch/arm/plat-omap/include/plat/cpu.h
@@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
#define cpu_class_is_omap1() (cpu_is_omap7xx() || cpu_is_omap15xx() || \
cpu_is_omap16xx())
#define cpu_class_is_omap2() (cpu_is_omap24xx() || cpu_is_omap34xx() || \
- cpu_is_omap44xx())
+ cpu_is_omap44xx() || soc_is_am33xx())
/* Various silicon revisions for omap2 */
#define OMAP242X_CLASS 0x24200024
--
1.7.0.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2
2012-06-09 14:56 [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2 Vaibhav Hiremath
@ 2012-06-11 6:38 ` Tony Lindgren
2012-06-11 6:44 ` Vaibhav Hiremath
0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2012-06-11 6:38 UTC (permalink / raw)
To: Vaibhav Hiremath; +Cc: linux-omap, linux-arm-kernel
* Vaibhav Hiremath <hvaibhav@ti.com> [120609 08:00]:
> Newly added AM33XX device falls under omap2 class, so
> make cpu_class_is_omap2() true for AM33XX
> (Add soc_is_am33xx() check).
>
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> ---
> arch/arm/plat-omap/include/plat/cpu.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h
> index 14f050f..5e36564 100644
> --- a/arch/arm/plat-omap/include/plat/cpu.h
> +++ b/arch/arm/plat-omap/include/plat/cpu.h
> @@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> #define cpu_class_is_omap1() (cpu_is_omap7xx() || cpu_is_omap15xx() || \
> cpu_is_omap16xx())
> #define cpu_class_is_omap2() (cpu_is_omap24xx() || cpu_is_omap34xx() || \
> - cpu_is_omap44xx())
> + cpu_is_omap44xx() || soc_is_am33xx())
>
> /* Various silicon revisions for omap2 */
> #define OMAP242X_CLASS 0x24200024
I think this can be now simply !cpu_class_is_omap1() as there is
a very slim chance that we'll ever be compiling omap1 and omap2+ together
because of the different compiler flags needed.
Regards,
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2
2012-06-11 6:38 ` Tony Lindgren
@ 2012-06-11 6:44 ` Vaibhav Hiremath
2012-06-11 6:48 ` Tony Lindgren
0 siblings, 1 reply; 4+ messages in thread
From: Vaibhav Hiremath @ 2012-06-11 6:44 UTC (permalink / raw)
To: Tony Lindgren; +Cc: linux-omap, linux-arm-kernel
On 6/11/2012 12:08 PM, Tony Lindgren wrote:
> * Vaibhav Hiremath <hvaibhav@ti.com> [120609 08:00]:
>> Newly added AM33XX device falls under omap2 class, so
>> make cpu_class_is_omap2() true for AM33XX
>> (Add soc_is_am33xx() check).
>>
>> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
>> ---
>> arch/arm/plat-omap/include/plat/cpu.h | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h
>> index 14f050f..5e36564 100644
>> --- a/arch/arm/plat-omap/include/plat/cpu.h
>> +++ b/arch/arm/plat-omap/include/plat/cpu.h
>> @@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
>> #define cpu_class_is_omap1() (cpu_is_omap7xx() || cpu_is_omap15xx() || \
>> cpu_is_omap16xx())
>> #define cpu_class_is_omap2() (cpu_is_omap24xx() || cpu_is_omap34xx() || \
>> - cpu_is_omap44xx())
>> + cpu_is_omap44xx() || soc_is_am33xx())
>>
>> /* Various silicon revisions for omap2 */
>> #define OMAP242X_CLASS 0x24200024
> I think this can be now simply !cpu_class_is_omap1() as there is
> a very slim chance that we'll ever be compiling omap1 and omap2+ together
> because of the different compiler flags needed.
>
> Regards,
>
> Tony
Ok...
Shall I submit patch with this change?
Thanks,
Vaibhav
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2
2012-06-11 6:44 ` Vaibhav Hiremath
@ 2012-06-11 6:48 ` Tony Lindgren
0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2012-06-11 6:48 UTC (permalink / raw)
To: Vaibhav Hiremath; +Cc: linux-omap, linux-arm-kernel
* Vaibhav Hiremath <hvaibhav@ti.com> [120610 23:49]:
> On 6/11/2012 12:08 PM, Tony Lindgren wrote:
> >* Vaibhav Hiremath <hvaibhav@ti.com> [120609 08:00]:
> >>Newly added AM33XX device falls under omap2 class, so
> >>make cpu_class_is_omap2() true for AM33XX
> >>(Add soc_is_am33xx() check).
> >>
> >>Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> >>---
> >> arch/arm/plat-omap/include/plat/cpu.h | 2 +-
> >> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >>diff --git a/arch/arm/plat-omap/include/plat/cpu.h b/arch/arm/plat-omap/include/plat/cpu.h
> >>index 14f050f..5e36564 100644
> >>--- a/arch/arm/plat-omap/include/plat/cpu.h
> >>+++ b/arch/arm/plat-omap/include/plat/cpu.h
> >>@@ -375,7 +375,7 @@ IS_OMAP_TYPE(3430, 0x3430)
> >> #define cpu_class_is_omap1() (cpu_is_omap7xx() || cpu_is_omap15xx() || \
> >> cpu_is_omap16xx())
> >> #define cpu_class_is_omap2() (cpu_is_omap24xx() || cpu_is_omap34xx() || \
> >>- cpu_is_omap44xx())
> >>+ cpu_is_omap44xx() || soc_is_am33xx())
> >> /* Various silicon revisions for omap2 */
> >> #define OMAP242X_CLASS 0x24200024
> >I think this can be now simply !cpu_class_is_omap1() as there is
> >a very slim chance that we'll ever be compiling omap1 and omap2+ together
> >because of the different compiler flags needed.
> >
> >Regards,
> >
> >Tony
>
> Ok...
>
> Shall I submit patch with this change?
Yes thanks.
Tony
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-06-11 6:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-09 14:56 [PATCH] ARM: OMAP2+: cpu: Add am33xx device under cpu_class_is_omap2 Vaibhav Hiremath
2012-06-11 6:38 ` Tony Lindgren
2012-06-11 6:44 ` Vaibhav Hiremath
2012-06-11 6:48 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox