From: Tony Lindgren <tony@atomide.com>
To: "Mohammed, Afzal" <afzal@ti.com>
Cc: "Hunter, Jon" <jon-hunter@ti.com>,
"paul@pwsan.com" <paul@pwsan.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings
Date: Wed, 13 Jun 2012 04:54:45 -0700 [thread overview]
Message-ID: <20120613115445.GM12766@atomide.com> (raw)
In-Reply-To: <20120613113217.GK12766@atomide.com>
* Tony Lindgren <tony@atomide.com> [120613 04:36]:
> * Mohammed, Afzal <afzal@ti.com> [120612 22:00]:
> > Hi Jon,
> >
> > On Tue, Jun 12, 2012 at 23:06:53, Hunter, Jon wrote:
> >
> > > Should you at least warn, if you are going to over-write a value?
> >
> > Yes, that would be better except for too much logging, if Tony
> > prefers that way I will add.
>
> If there's a chance it causing file system corruption, we should
> test it carefully on the boards before applying. If that's done,
> then there's probably no need for warnings. It's safer to disable
> NAND for untested boards if there's a chance of breaking the timings.
Actually this patch breaks at least DMA on tusb6010 on n8x0. That's
a MUSB hardware in a wrapper connected to GPMC that's very picky with
the timings.
Got any hints what should be done with the cycle2cycle stuff for
tusb6010?
Tony
next prev parent reply other threads:[~2012-06-13 11:54 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 14:01 [PATCH 0/3] Prepare for GPMC driver conversion Afzal Mohammed
2012-06-11 14:01 ` [PATCH 1/3] ARM: OMAP2+: nand: unify init functions Afzal Mohammed
2012-06-11 15:43 ` Jon Hunter
2012-06-12 5:50 ` Mohammed, Afzal
2012-06-11 14:01 ` [PATCH 2/3] ARM: OMAP2+: onenand: cleanup for gpmc driver conversion Afzal Mohammed
2012-06-11 18:36 ` Jon Hunter
2012-06-12 6:16 ` Mohammed, Afzal
2012-06-12 17:30 ` Jon Hunter
2012-06-13 5:03 ` Mohammed, Afzal
2012-06-13 16:38 ` Jon Hunter
2012-06-14 5:40 ` Mohammed, Afzal
2012-06-14 17:53 ` Jon Hunter
2012-06-15 6:52 ` Mohammed, Afzal
2012-06-11 14:02 ` [PATCH 3/3] ARM: OMAP2+: gpmc: handle additional timings Afzal Mohammed
2012-06-11 18:49 ` Jon Hunter
2012-06-12 6:37 ` Mohammed, Afzal
2012-06-12 17:36 ` Jon Hunter
2012-06-13 4:56 ` Mohammed, Afzal
2012-06-13 11:32 ` Tony Lindgren
2012-06-13 11:54 ` Tony Lindgren [this message]
2012-06-13 11:58 ` Mohammed, Afzal
2012-06-14 10:10 ` Mohammed, Afzal
2012-06-14 10:19 ` Tony Lindgren
2012-06-14 10:39 ` Mohammed, Afzal
2012-06-14 11:49 ` Tony Lindgren
2012-06-14 11:59 ` Mohammed, Afzal
2012-06-14 12:09 ` Mohammed, Afzal
2012-06-14 12:21 ` Mohammed, Afzal
2012-06-14 12:30 ` Tony Lindgren
2012-06-14 11:52 ` Tony Lindgren
2012-06-14 11:56 ` Mohammed, Afzal
2012-06-14 12:29 ` Tony Lindgren
2012-06-14 12:53 ` Mohammed, Afzal
2012-06-14 16:53 ` Tony Lindgren
2012-06-15 5:42 ` Mohammed, Afzal
2012-06-15 6:16 ` Mohammed, Afzal
2012-06-15 10:45 ` Tony Lindgren
2012-06-15 10:49 ` Mohammed, Afzal
2012-06-13 12:34 ` Mohammed, Afzal
2012-06-13 12:42 ` Tony Lindgren
2012-06-13 14:04 ` Mohammed, Afzal
2012-06-14 6:32 ` Tony Lindgren
2012-06-14 9:29 ` Tony Lindgren
2012-06-14 9:41 ` Mohammed, Afzal
2012-06-14 11:23 ` Tony Lindgren
2012-06-12 10:27 ` [PATCH 0/3] Prepare for GPMC driver conversion Mohammed, Afzal
2012-06-13 11:33 ` Tony Lindgren
2012-06-13 12:40 ` Mohammed, Afzal
2012-06-13 16:46 ` Jon Hunter
2012-06-14 5:58 ` Mohammed, Afzal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120613115445.GM12766@atomide.com \
--to=tony@atomide.com \
--cc=afzal@ti.com \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox