From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v5 04/14] ARM: OMAP2+: gpmc: minimal driver support Date: Thu, 14 Jun 2012 01:39:58 -0700 Message-ID: <20120614083957.GC12766@atomide.com> References: <4FD6586A.9060706@ti.com> <4FD782F7.9010003@ti.com> <20120613120717.GP12766@atomide.com> <20120613134032.GW12766@atomide.com> <20120613134408.GY12766@atomide.com> <20120614063524.GB12766@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:21523 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754595Ab2FNIkD (ORCPT ); Thu, 14 Jun 2012 04:40:03 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Mohammed, Afzal" Cc: "Hunter, Jon" , "paul@pwsan.com" , "linux-omap@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" * Mohammed, Afzal [120613 23:44]: > Hi Tony, > > On Thu, Jun 14, 2012 at 12:05:25, Tony Lindgren wrote: > > * Mohammed, Afzal [120613 06:56]: > > > > > Or you meant, even there read revision register ? > > > > Yeah that should be fine as this really should only happen > > during init and whatever revision specific features can > > be initialized for GPMC. > > Sorry, I got confused, we need revision to be available while setting > time also, so you meant to store it as a variable or read revision > at probe as well as during setting time ? You can set up GPMC specific flags during init, something like OMAP_GPMC_HAS_XYZ, or you can set up function pointers if only some features are available on some revisions. Regards, Tony