From: Tony Lindgren <tony@atomide.com>
To: Afzal Mohammed <afzal@ti.com>
Cc: paul@pwsan.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 6/9] ARM: OMAP2+: gpmc-smsc911x: Adapt to use gpmc driver
Date: Thu, 14 Jun 2012 01:56:52 -0700 [thread overview]
Message-ID: <20120614085650.GD12766@atomide.com> (raw)
In-Reply-To: <fa4fd074305f914d38603443b857422f95680725.1339419379.git.afzal@ti.com>
* Afzal Mohammed <afzal@ti.com> [120611 08:20]:
> +__init gpmc_smsc911x_update(struct omap_smsc911x_platform_data *gpmc_cfg)
> +{
> + int ret;
> + struct gpmc_device_pdata *gpmc_pdev;
> + struct gpmc_cs_data *gpmc_cs;
> +
> + gpmc_pdev = kzalloc(sizeof(*gpmc_pdev), GFP_KERNEL);
> + if (gpmc_pdev == NULL)
> + return gpmc_pdev;
> +
> + gpmc_cs = kzalloc(sizeof(*gpmc_cs), GFP_KERNEL);
> + if (gpmc_pdev == NULL) {
> + kfree(gpmc_pdev);
> + return NULL;
> + }
Here your should check for if (!gpmc_cs), not gpmc_cs. Might
be worth checking all your patches for similar copy and paste
typos.
Where do gpmc_pdev and gpmc_cs get used? Where are they
stored to the pdata?
Tony
next prev parent reply other threads:[~2012-06-14 8:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 14:58 [PATCH 0/9] Adapt GPMC peripherals, platforms to driver Afzal Mohammed
2012-06-11 14:59 ` [PATCH 1/9] ARM: OMAP2+: gpmc-nand: Adapt to use gpmc driver Afzal Mohammed
2012-06-11 14:59 ` [PATCH 2/9] ARM: OMAP2+: gpmc-onenand: " Afzal Mohammed
2012-06-11 14:59 ` [PATCH 3/9] ARM: OMAP2+: flash: " Afzal Mohammed
2012-06-11 14:59 ` [PATCH 4/9] ARM: OMAP2+: gpmc-tusb6010: " Afzal Mohammed
2012-06-13 12:27 ` Tony Lindgren
2012-06-13 13:14 ` Mohammed, Afzal
2012-06-11 14:59 ` [PATCH 5/9] ARM: OMAP2+: gpmc-smc91x: " Afzal Mohammed
2012-06-13 12:29 ` Tony Lindgren
2012-06-13 13:39 ` Mohammed, Afzal
2012-06-13 13:43 ` Tony Lindgren
2012-06-14 9:26 ` Mohammed, Afzal
2012-06-11 14:59 ` [PATCH 6/9] ARM: OMAP2+: gpmc-smsc911x: " Afzal Mohammed
2012-06-14 8:56 ` Tony Lindgren [this message]
2012-06-14 9:07 ` Mohammed, Afzal
2012-06-11 14:59 ` [PATCH 7/9] ARM: OMAP2+: gpmc-smsc911x: runtime time calculation Afzal Mohammed
2012-06-11 14:59 ` [PATCH 8/9] ARM: OMAP2+: board omap3evm: use gpmc driver Afzal Mohammed
2012-06-11 15:00 ` [PATCH 9/9] ARM: OMAP2+: board omap3beagle: " Afzal Mohammed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614085650.GD12766@atomide.com \
--to=tony@atomide.com \
--cc=afzal@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox