From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Santosh Shilimkar <santosh.shilimkar@ti.com>
Cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org,
linux-omap@vger.kernel.org, Aneesh V <aneesh@ti.com>
Subject: Re: [PATCH v3 4/4] memory: emif: add device tree support to emif driver
Date: Thu, 14 Jun 2012 08:48:20 -0700 [thread overview]
Message-ID: <20120614154820.GG17140@kroah.com> (raw)
In-Reply-To: <1339669764-27244-5-git-send-email-santosh.shilimkar@ti.com>
On Thu, Jun 14, 2012 at 03:59:24PM +0530, Santosh Shilimkar wrote:
> From: Aneesh V <aneesh@ti.com>
>
> Device tree support for the EMIF driver.
>
> Reviewed-by: Benoit Cousson <b-cousson@ti.com>
> Reviewed-by: Grant Likely <grant.likely@secretlab.ca>
> Tested-by: Lokesh Vutla <lokeshvutla@ti.com>
> Signed-off-by: Aneesh V <aneesh@ti.com>
> [santosh.shilimkar@ti.com: Rebased against 3.5-rc]
> Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Am I the memory maintainer now taking these patches?
> @@ -1267,7 +1534,13 @@ static int __init_or_module emif_probe(struct platform_device *pdev)
> struct resource *res;
> int irq;
>
> - emif = get_device_details(pdev);
> +#if defined(CONFIG_OF)
> + if (pdev->dev.of_node)
> + emif = of_get_device_details(pdev->dev.of_node, &pdev->dev);
> + else
> +#endif
> + emif = get_device_details(pdev);
> +
Can't you do this without the #ifdef?
thanks,
greg k-h
next prev parent reply other threads:[~2012-06-14 15:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-14 10:29 [PATCH v3 0/4] dt: device tree support for TI EMIF driver for 3.6 Santosh Shilimkar
2012-06-14 10:29 ` [PATCH v3 1/4] dt: device tree bindings for LPDDR2 memories Santosh Shilimkar
2012-06-14 10:29 ` [PATCH v3 2/4] dt: emif: device tree bindings for TI's EMIF sdram controller Santosh Shilimkar
2012-06-14 10:29 ` [PATCH v3 3/4] arm: dts: EMIF and LPDDR2 device tree data for OMAP4 boards Santosh Shilimkar
2012-06-14 10:29 ` [PATCH v3 4/4] memory: emif: add device tree support to emif driver Santosh Shilimkar
2012-06-14 15:48 ` Greg Kroah-Hartman [this message]
2012-06-15 7:06 ` Shilimkar, Santosh
2012-06-19 9:03 ` Shilimkar, Santosh
2012-06-25 18:28 ` Greg Kroah-Hartman
2012-06-26 5:09 ` Shilimkar, Santosh
2012-06-26 5:19 ` Rajendra Nayak
2012-06-26 5:23 ` Shilimkar, Santosh
2012-06-26 5:26 ` Rajendra Nayak
2012-06-26 7:49 ` Shilimkar, Santosh
2012-06-29 13:46 ` Shilimkar, Santosh
2012-06-29 21:07 ` Greg Kroah-Hartman
2012-06-29 21:28 ` Jon Hunter
2012-06-30 2:50 ` Greg Kroah-Hartman
2012-06-30 4:14 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120614154820.GG17140@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aneesh@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox