* board_onenand_init() build error in linux-next
@ 2012-06-15 12:46 Joe Woodward
2012-06-20 14:24 ` Tony Lindgren
0 siblings, 1 reply; 2+ messages in thread
From: Joe Woodward @ 2012-06-15 12:46 UTC (permalink / raw)
To: linux-omap@vger.kernel.org
Someone may have spotted this already...
But if you build todays linux-next (next-20120615) without CONFIG_MTD_ONENAND_OMAP2 or
CONFIG_MTD_ONENAND_OMAP2_MODULE then board_onenand_init() is defined in two places
(in board-flash.c:102 as an empty function, and board-flash.h:56 as a static inline).
This causes the build to fail as board-flash.c includes board-flash.h:
CC arch/arm/mach-omap2/board-flash.o
arch/arm/mach-omap2/board-flash.c:102:8: error: redefinition of 'board_onenand_init'
arch/arm/mach-omap2/board-flash.h:56:20: note: previous definition of 'board_onenand_init'
was here
make[1]: *** [arch/arm/mach-omap2/board-flash.o] Error 1
I'm fairly sure this isn't right!?
Cheers,
Joe
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: board_onenand_init() build error in linux-next
2012-06-15 12:46 board_onenand_init() build error in linux-next Joe Woodward
@ 2012-06-20 14:24 ` Tony Lindgren
0 siblings, 0 replies; 2+ messages in thread
From: Tony Lindgren @ 2012-06-20 14:24 UTC (permalink / raw)
To: Joe Woodward; +Cc: linux-omap@vger.kernel.org
* Joe Woodward <jw@terrafix.co.uk> [120615 05:51]:
> Someone may have spotted this already...
>
> But if you build todays linux-next (next-20120615) without CONFIG_MTD_ONENAND_OMAP2 or
> CONFIG_MTD_ONENAND_OMAP2_MODULE then board_onenand_init() is defined in two places
> (in board-flash.c:102 as an empty function, and board-flash.h:56 as a static inline).
>
> This causes the build to fail as board-flash.c includes board-flash.h:
> CC arch/arm/mach-omap2/board-flash.o
> arch/arm/mach-omap2/board-flash.c:102:8: error: redefinition of 'board_onenand_init'
> arch/arm/mach-omap2/board-flash.h:56:20: note: previous definition of 'board_onenand_init'
> was here
> make[1]: *** [arch/arm/mach-omap2/board-flash.o] Error 1
>
> I'm fairly sure this isn't right!?
Yeah sounds like a bug, got a patch for it?
Tony
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-06-20 14:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-15 12:46 board_onenand_init() build error in linux-next Joe Woodward
2012-06-20 14:24 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox