[PATCH] spi: omap2-mcspi: fix section mismatch regression in probe

[PATCH] spi: omap2-mcspi: fix section mismatch regression in probe

[Venkatraman S]

Commit 7d6b6d83(make it behave as a module) annotated probe with
__devinit, but a referenced function was not.

This introduced a section mismatch warning:
WARNING: vmlinux.o(.devinit.text+0x3eec): Section mismatch in reference
from the function omap2_mcspi_probe() to the function
.init.text:omap2_mcspi_master_setup()

Signed-off-by: Venkatraman S <svenkatr@ti.com>
---
 drivers/spi/spi-omap2-mcspi.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
index 46ef5fe..1618e89 100644
--- a/drivers/spi/spi-omap2-mcspi.c
+++ b/drivers/spi/spi-omap2-mcspi.c
@@ -1031,7 +1031,7 @@ static int omap2_mcspi_transfer_one_message(struct spi_master *master,
 	return 0;
 }
 
-static int __init omap2_mcspi_master_setup(struct omap2_mcspi *mcspi)
+static int __devinit omap2_mcspi_master_setup(struct omap2_mcspi *mcspi)
 {
 	struct spi_master	*master = mcspi->master;
 	struct omap2_mcspi_regs	*ctx = &mcspi->ctx;
-- 
1.7.0.4

Re: [PATCH] spi: omap2-mcspi: fix section mismatch regression in probe

[Felipe Balbi]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

On Tue, Jun 19, 2012 at 03:27:48PM +0530, Venkatraman S wrote:
> Commit 7d6b6d83(make it behave as a module) annotated probe with
> __devinit, but a referenced function was not.
> 
> This introduced a section mismatch warning:
> WARNING: vmlinux.o(.devinit.text+0x3eec): Section mismatch in reference
> from the function omap2_mcspi_probe() to the function
> .init.text:omap2_mcspi_master_setup()
> 
> Signed-off-by: Venkatraman S <svenkatr@ti.com>

Acked-by: Felipe Balbi <balbi@ti.com>

my apologies

> ---
>  drivers/spi/spi-omap2-mcspi.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/spi/spi-omap2-mcspi.c b/drivers/spi/spi-omap2-mcspi.c
> index 46ef5fe..1618e89 100644
> --- a/drivers/spi/spi-omap2-mcspi.c
> +++ b/drivers/spi/spi-omap2-mcspi.c
> @@ -1031,7 +1031,7 @@ static int omap2_mcspi_transfer_one_message(struct spi_master *master,
>  	return 0;
>  }
>  
> -static int __init omap2_mcspi_master_setup(struct omap2_mcspi *mcspi)
> +static int __devinit omap2_mcspi_master_setup(struct omap2_mcspi *mcspi)
>  {
>  	struct spi_master	*master = mcspi->master;
>  	struct omap2_mcspi_regs	*ctx = &mcspi->ctx;
> -- 
> 1.7.0.4
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]