public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org,
	linux-omap@vger.kernel.org, Aneesh V <aneesh@ti.com>
Subject: Re: [PATCH v3 4/4] memory: emif: add device tree support to emif driver
Date: Mon, 25 Jun 2012 11:28:30 -0700	[thread overview]
Message-ID: <20120625182830.GA23850@kroah.com> (raw)
In-Reply-To: <CAMQu2gy7oj-+1qCteAFMXEeOL-Wdrs6e4gKWM=HsOukXcPuv-A@mail.gmail.com>

On Tue, Jun 19, 2012 at 02:33:11PM +0530, Shilimkar, Santosh wrote:
> @@ -1644,11 +1923,23 @@ static void __attribute__((unused))
> freq_post_notify_handling(void)
>  	spin_unlock_irqrestore(&emif_lock, irq_state);
>  }
> 
> +#if defined(CONFIG_OF)
> +static const struct of_device_id emif_of_match[] = {
> +		{ .compatible = "ti,emif-4d" },
> +		{ .compatible = "ti,emif-4d5" },
> +		{},
> +};
> +MODULE_DEVICE_TABLE(of, emif_of_match);
> +#endif
> +
>  static struct platform_driver emif_driver = {
>  	.remove		= __exit_p(emif_remove),
>  	.shutdown	= emif_shutdown,
>  	.driver = {
>  		.name = "emif",
> +#if defined(CONFIG_OF)
> +		.of_match_table = of_match_ptr(emif_of_match),
> +#endif

Are these two still #if defined needed?

Also, what about the IS_DEFINED macro?

And, if you resend, please resend the whole series, I don't have the old
ones around anymore.

thanks,

greg k-h

  reply	other threads:[~2012-06-25 18:28 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-14 10:29 [PATCH v3 0/4] dt: device tree support for TI EMIF driver for 3.6 Santosh Shilimkar
2012-06-14 10:29 ` [PATCH v3 1/4] dt: device tree bindings for LPDDR2 memories Santosh Shilimkar
2012-06-14 10:29 ` [PATCH v3 2/4] dt: emif: device tree bindings for TI's EMIF sdram controller Santosh Shilimkar
2012-06-14 10:29 ` [PATCH v3 3/4] arm: dts: EMIF and LPDDR2 device tree data for OMAP4 boards Santosh Shilimkar
2012-06-14 10:29 ` [PATCH v3 4/4] memory: emif: add device tree support to emif driver Santosh Shilimkar
2012-06-14 15:48   ` Greg Kroah-Hartman
2012-06-15  7:06     ` Shilimkar, Santosh
2012-06-19  9:03       ` Shilimkar, Santosh
2012-06-25 18:28         ` Greg Kroah-Hartman [this message]
2012-06-26  5:09           ` Shilimkar, Santosh
2012-06-26  5:19             ` Rajendra Nayak
2012-06-26  5:23               ` Shilimkar, Santosh
2012-06-26  5:26                 ` Rajendra Nayak
2012-06-26  7:49                   ` Shilimkar, Santosh
2012-06-29 13:46                     ` Shilimkar, Santosh
2012-06-29 21:07                       ` Greg Kroah-Hartman
2012-06-29 21:28                         ` Jon Hunter
2012-06-30  2:50                           ` Greg Kroah-Hartman
2012-06-30  4:14                             ` Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120625182830.GA23850@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=aneesh@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=santosh.shilimkar@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox