From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH v3 4/4] memory: emif: add device tree support to emif driver Date: Fri, 29 Jun 2012 17:07:52 -0400 Message-ID: <20120629210752.GA13859@kroah.com> References: <20120614154820.GG17140@kroah.com> <20120625182830.GA23850@kroah.com> <4FE9467A.2050906@ti.com> <4FE947F7.9030000@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mail-yw0-f42.google.com ([209.85.213.42]:39943 "EHLO mail-yw0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932289Ab2F2VIU (ORCPT ); Fri, 29 Jun 2012 17:08:20 -0400 Received: by yhfq11 with SMTP id q11so4572215yhf.1 for ; Fri, 29 Jun 2012 14:08:19 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: tony@atomide.com, linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Aneesh V On Fri, Jun 29, 2012 at 07:16:19PM +0530, Shilimkar, Santosh wrote: > Greg, >=20 > On Tue, Jun 26, 2012 at 1:19 PM, Shilimkar, Santosh > wrote: > > > > On Tue, Jun 26, 2012 at 10:56 AM, Rajendra Nayak wr= ote: > > > On Tuesday 26 June 2012 10:53 AM, Shilimkar, Santosh wrote: > > >> > > >> On Tue, Jun 26, 2012 at 10:49 AM, Rajendra Nayak = =A0wrote: > > >>> > > >>> On Tuesday 26 June 2012 10:39 AM, Shilimkar, Santosh wrote: > > >>>>>> > > >>>>>> > > >>>>>> +#if defined(CONFIG_OF) > > >>>>>>> > > >>>>>>> =A0> =A0 =A0+static const struct of_device_id emif_of_match= [] =3D { > > >>>>>>> =A0> =A0 =A0+ =A0 =A0 =A0 =A0 =A0 =A0 { .compatible =3D "ti= ,emif-4d" }, > > >>>>>>> =A0> =A0 =A0+ =A0 =A0 =A0 =A0 =A0 =A0 { .compatible =3D "ti= ,emif-4d5" }, > > >>>>>>> =A0> =A0 =A0+ =A0 =A0 =A0 =A0 =A0 =A0 {}, > > >>>>>>> =A0> =A0 =A0+}; > > >>>>>>> =A0> =A0 =A0+MODULE_DEVICE_TABLE(of, emif_of_match); > > >>>>>>> =A0> =A0 =A0+#endif > > >>>>>>> =A0> =A0 =A0+ > > >>>>>>> =A0> =A0 =A0 =A0static struct platform_driver emif_driver =3D= { > > >>>>>>> =A0> =A0 =A0 =A0 =A0 =A0 .remove =A0 =A0 =A0 =A0 =3D __exit= _p(emif_remove), > > >>>>>>> =A0> =A0 =A0 =A0 =A0 =A0 .shutdown =A0 =A0 =A0 =3D emif_shu= tdown, > > >>>>>>> =A0> =A0 =A0 =A0 =A0 =A0 .driver =3D { > > >>>>>>> =A0> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 .name =3D "emif", > > >>>>>>> =A0> =A0 =A0+#if defined(CONFIG_OF) > > >>>>>>> =A0> =A0 =A0+ =A0 =A0 =A0 =A0 =A0 =A0 .of_match_table =3D o= f_match_ptr(emif_of_match), > > >>>>>>> =A0> =A0 =A0+#endif > > >>>>> > > >>>>> > > >>>>>> > > >>>>>> =A0Are these two still #if defined needed? > > >>>>>> > > >>>>>> =A0Also, what about the IS_DEFINED macro? > > >>>>>> > > >>>> > > >>>> Yes. To avoid the build break in !DT build. > > >>>> > > >>> > > >>> No, infact of_match_ptr is there just so you can avoid a > > >>> #ifdef around and not break !CONFIG_OF. > > >> > > >> > > >> Need to recheck but the build was throwing error becasue of > > >> "emif_of_match" > > >> mostly. > > > > > > > > > You still need the first one. I meant the second one around > > > 'of_match_ptr' should be removed. > > > > > > With !CONFIG_OF, of_match_ptr(_ptr) is just defined as NULL. > > > > > Yep. That make sense too. > > Will drop the second check. > > > Posted the entire series again with updated $subject patch. > With your ack, I will ask Tony to pull this series for 3.6. Sent them where? I didn't see a copy here :( -- To unsubscribe from this list: send the line "unsubscribe linux-omap" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html