From: Greg KH <gregkh@linuxfoundation.org>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org,
Aneesh V <aneesh@ti.com>,
tony@atomide.com
Subject: Re: [PATCH v4 4/4] memory: emif: add device tree support to emif driver
Date: Sat, 30 Jun 2012 00:23:56 -0400 [thread overview]
Message-ID: <20120630042356.GC1816@kroah.com> (raw)
In-Reply-To: <CAMQu2gz6jdcR4hQPPbmyO8vrkdmppHeCkZmV3_9w27LOzKrUuA@mail.gmail.com>
On Sat, Jun 30, 2012 at 09:38:41AM +0530, Shilimkar, Santosh wrote:
> (+ Greg, By mistake the your name got dropped cc from list)
>
> On Fri, Jun 29, 2012 at 7:13 PM, Santosh Shilimkar
> <santosh.shilimkar@ti.com> wrote:
> > From: Aneesh V <aneesh@ti.com>
> >
> > Device tree support for the EMIF driver.
> >
> > Reviewed-by: Benoit Cousson <b-cousson@ti.com>
> > Reviewed-by: Grant Likely <grant.likely@secretlab.ca>
> > Tested-by: Lokesh Vutla <lokeshvutla@ti.com>
> > Signed-off-by: Aneesh V <aneesh@ti.com>
> > [santosh.shilimkar@ti.com: Rebased against 3.5-rc]
> > Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
> > ---
> > drivers/memory/emif.c | 291 ++++++++++++++++++++++++++++++++++++++++++++++++-
> > 1 file changed, 290 insertions(+), 1 deletion(-)
Wouldn't this just be better off as a separate file that only gets build
if CONFIG_OF is set, as I'm sure that other systems are going to want
access to these "read the device tree values" functions, right?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-30 4:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-29 13:43 [PATCH v4 0/4] dt: device tree support for TI EMIF driver for 3.6 Santosh Shilimkar
2012-06-29 13:43 ` [PATCH v4 1/4] dt: device tree bindings for LPDDR2 memories Santosh Shilimkar
2012-06-29 13:43 ` [PATCH v4 2/4] dt: emif: device tree bindings for TI's EMIF sdram controller Santosh Shilimkar
2012-06-29 13:43 ` [PATCH v4 3/4] arm: dts: EMIF and LPDDR2 device tree data for OMAP4 boards Santosh Shilimkar
2012-06-29 13:43 ` [PATCH v4 4/4] memory: emif: add device tree support to emif driver Santosh Shilimkar
2012-06-30 4:08 ` Shilimkar, Santosh
2012-06-30 4:23 ` Greg KH [this message]
2012-06-30 4:42 ` Shilimkar, Santosh
2012-07-02 13:18 ` Shilimkar, Santosh
2012-07-09 13:32 ` Shilimkar, Santosh
2012-07-17 16:36 ` Greg KH
2012-07-17 17:07 ` Shilimkar, Santosh
2012-07-17 17:58 ` Greg KH
2012-07-18 6:44 ` Shilimkar, Santosh
2012-08-13 5:27 ` Shilimkar, Santosh
2012-08-16 18:45 ` Greg KH
2012-08-17 8:50 ` Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120630042356.GC1816@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aneesh@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox