From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v1 03/14] ARM: OMAP5: id: Add cpu id for ES versions Date: Thu, 5 Jul 2012 07:26:38 -0700 Message-ID: <20120705142637.GD1122@atomide.com> References: <1341490136-25901-1-git-send-email-santosh.shilimkar@ti.com> <1341490136-25901-6-git-send-email-santosh.shilimkar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:51186 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229Ab2GEO0l (ORCPT ); Thu, 5 Jul 2012 10:26:41 -0400 Content-Disposition: inline In-Reply-To: <1341490136-25901-6-git-send-email-santosh.shilimkar@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Santosh Shilimkar Cc: linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, R Sricharan Hi, * Santosh Shilimkar [120705 05:13]: > From: R Sricharan > > Adding the OMAP5 ES1.0, 2.0 and OMAP5432 cpu revision > detection support. > > --- a/arch/arm/mach-omap2/id.c > +++ b/arch/arm/mach-omap2/id.c > @@ -50,6 +50,11 @@ int omap_type(void) > val = omap_ctrl_readl(OMAP343X_CONTROL_STATUS); > } else if (cpu_is_omap44xx()) { > val = omap_ctrl_readl(OMAP4_CTRL_MODULE_CORE_STATUS); > + } else if (cpu_is_omap54xx()) { > + val = omap_ctrl_readl(OMAP5XXX_CONTROL_STATUS); > + val &= OMAP5_DEVICETYPE_MASK; > + val >>= 6; > + goto out; > } else { > pr_err("Cannot detect omap type!\n"); > goto out; > @@ -100,7 +105,7 @@ static u16 tap_prod_id; > > void omap_get_die_id(struct omap_die_id *odi) > { > - if (cpu_is_omap44xx()) { > + if (cpu_is_omap44xx() || cpu_is_omap54xx()) { Please update all these patches to use soc_is_omap54xx() instead of cpu_is_omap54xx() as that's where we are heading. Regards, Tony