From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ladislav Michl Subject: Re: [PATCH] ARM: OMAP AM35x: clockdomain data: fix resolving dependency problem Date: Sat, 7 Jul 2012 14:41:31 +0200 Message-ID: <20120707124131.GA9034@localhost.localdomain> References: <20120702174138.GA9669@animalcreek.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from eddie.linux-mips.org ([78.24.191.182]:55708 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750736Ab2GGMlo (ORCPT ); Sat, 7 Jul 2012 08:41:44 -0400 Received: (from localhost user: 'ladis' uid#521 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S1903526Ab2GGMll (ORCPT ); Sat, 7 Jul 2012 14:41:41 +0200 Content-Disposition: inline In-Reply-To: <20120702174138.GA9669@animalcreek.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Mark A. Greer" Cc: "Kim, Milo" , "tony@atomide.com" , "linux-omap@vger.kernel.org" On Mon, Jul 02, 2012 at 10:41:38AM -0700, Mark A. Greer wrote: > On Mon, Jul 02, 2012 at 05:54:57AM +0000, Kim, Milo wrote: > > In am35x board , iva2 clock domain doesn't be used. > > So mpu_am35x_clkdm should be used rather than mpu_3xxx_clkdm. > > OMAP3430 : mpu_3xxx_clkdm (with iva2 clkdm) > > AM35x : mpu_am35x_clkdm (without iva2 clkdm) > > > > For the compatibility with omap3430, this patch has no conflict because mpu_3xxx_clkdm was already defined in clock domains for omap3430. > > So this can be removed from common clock domain. > > > > Below error can be fixed with this patch. > > > > [ 0.000000] AM3517 ES1.1 (l2cache sgx neon ) > > [ 0.000000] ------------[ cut here ]------------ > > [ 0.000000] WARNING: at arch/arm/mach-omap2/clockdomain.c:237 _resolve_clkdm_deps+0x68/0x108() > > [ 0.000000] clockdomain: mpu_clkdm: could not find clkdm iva2_clkdm while resolving dependencies - should never happen > > [ 0.000000] Modules linked in: > > [ 0.000000] [] (unwind_backtrace+0x0/0xf4) from [] (warn_slowpath_common+0x4c/0x64) > > [ 0.000000] [] (warn_slowpath_common+0x4c/0x64) from [] (warn_slowpath_fmt+0x30/0x40) > > [ 0.000000] [] (warn_slowpath_fmt+0x30/0x40) from [] (_resolve_clkdm_deps+0x68/0x108) > > [ 0.000000] [] (_resolve_clkdm_deps+0x68/0x108) from [] (clkdm_complete_init+0x34/0x90) > > [ 0.000000] [] (clkdm_complete_init+0x34/0x90) from [] (omap3_init_early+0x20/0x30) > > [ 0.000000] [] (omap3_init_early+0x20/0x30) from [] (setup_arch+0x834/0x94c) > > [ 0.000000] [] (setup_arch+0x834/0x94c) from [] (start_kernel+0x88/0x2fc) > > [ 0.000000] [] (start_kernel+0x88/0x2fc) from [<80008044>] (0x80008044) > > > > Signed-off-by: Milo(Woogyom) Kim > > --- > > arch/arm/mach-omap2/clockdomains3xxx_data.c | 1 - > > 1 files changed, 0 insertions(+), 1 deletions(-) > > > > diff --git a/arch/arm/mach-omap2/clockdomains3xxx_data.c b/arch/arm/mach-omap2/clockdomains3xxx_data.c > > index d625844..56089c4 100644 > > --- a/arch/arm/mach-omap2/clockdomains3xxx_data.c > > +++ b/arch/arm/mach-omap2/clockdomains3xxx_data.c > > @@ -454,7 +454,6 @@ static struct clkdm_autodep clkdm_am35x_autodeps[] = { > > > > static struct clockdomain *clockdomains_common[] __initdata = { > > &wkup_common_clkdm, > > - &mpu_3xxx_clkdm, > > &neon_clkdm, > > &core_l3_3xxx_clkdm, > > &core_l4_3xxx_clkdm, > > -- > > 1.7.2.5 > > Hi Milo. > > Thanks for the patch but this issue should already be fixed in a patch > that Tony just made a pull request for > (http://www.spinics.net/lists/linux-omap/msg73080.html). > > >From that email (and branch in the email), look for this patch: > > > Mark A. Greer (4): > > > ARM: OMAP AM35x: clockdomain data: Fix clockdomain dependencies > > Please take a look as another set of eyes never hurts. :) Hi Mark, just tested above patch on Technexion's TAM-3517 and it indeed fixes above warning. Without patch, warning is generated. Tested on Tony's master branch. ladis