From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v2 1/2] ARM: OMAP: board-4430sdp: MUX configuration for sys_nirq2 Date: Mon, 9 Jul 2012 05:14:00 -0700 Message-ID: <20120709121400.GF1122@atomide.com> References: <1341580752-5501-1-git-send-email-peter.ujfalusi@ti.com> <1341580752-5501-2-git-send-email-peter.ujfalusi@ti.com> <874nplc6va.fsf@ti.com> <4FFAA6AF.2010004@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-02-ewr.mailhop.org ([204.13.248.72]:17913 "EHLO mho-02-ewr.mailhop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753389Ab2GIMOC (ORCPT ); Mon, 9 Jul 2012 08:14:02 -0400 Content-Disposition: inline In-Reply-To: <4FFAA6AF.2010004@ti.com> Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: Peter Ujfalusi Cc: "Shilimkar, Santosh" , Kevin Hilman , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org * Peter Ujfalusi [120709 02:43]: > On 07/06/2012 04:33 PM, Shilimkar, Santosh wrote: > >> Since this is TWL6030 specific, it should rather be done in TWL code > >> like I did for sys_nirq1: > >> > >> http://marc.info/?l=linux-omap&m=134090312118873&w=2 > >> > >> That would avoid having to do this in both board files. > >> > > Though the pin is TWL specific, it need not be same on > > different board with different SOCs. Especially when you need to > > set MUX mode etc. So doing from board file is still better > > since TWL6030/40 can be connected to non OMAP4 devices > > where the muxing can be different. > > > > With current know boards with TWL6030/40, this is not > > a strong requirement though. > > There can be board which has twl6030 but does not have twl6040. > The twl6040 is the recommended audio solution for OMAP4+ systems but it can be > replaced by other codec on some boards. > This is the reason I have put the mux configuration into the board files for > sys_nirq2 (which is in these cases are used to handle the interrupt from twl6040). OK I'll apply these into devel-board branch. Tony