From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Kevin Hilman <khilman@ti.com>,
Alessandro Zummo <a.zummo@towertech.it>,
rtc-linux@googlegroups.com, linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT
Date: Tue, 10 Jul 2012 12:54:19 +0100 [thread overview]
Message-ID: <20120710115418.GA2280@sirena.org.uk> (raw)
In-Reply-To: <20120709151527.58f44c3a.akpm@linux-foundation.org>
On Mon, Jul 09, 2012 at 03:15:27PM -0700, Andrew Morton wrote:
> OK, this is the second such patch I've seen and it's time to wonder if
> we should get grumpy at tglx. afacit 1c6c6952 broke the following
> drivers:
> sound/soc/codecs/wm8994.c
> drivers/mfd/wm831x-auxadc.c
> drivers/mfd/wm8350-core.c
> drivers/regulator/wm831x-isink.c
> drivers/regulator/wm831x-ldo.c
> drivers/regulator/wm831x-dcdc.c
> drivers/input/misc/wm831x-on.c
> what am I missing here?
At least the above (and possibly a good proportion of the others from
the looks of things) aren't affected by this change because they are
nested IRQs for MFDs where we can guarantee that there will never be a
primary IRQ. _ONESHOT shouldn't make any odds in these situations.
> drivers/base/regmap/regmap-irq.c
This is using irq_flags passed in by the caller so should be unaffected,
it's always been the responsibility of the caller to set the flags.
next prev parent reply other threads:[~2012-07-10 11:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-06 16:33 [PATCH] drivers/rtc/rtc-twl.c: fix threaded IRQ to use IRQF_ONESHOT Kevin Hilman
2012-07-09 22:15 ` Andrew Morton
2012-07-10 7:32 ` Lars-Peter Clausen
2012-07-10 11:54 ` Mark Brown [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-06-28 16:17 Kevin Hilman
2012-07-06 14:25 ` Hilman, Kevin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120710115418.GA2280@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=a.zummo@towertech.it \
--cc=akpm@linux-foundation.org \
--cc=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).