* [PATCH V2] Add missing modules aliases to get sound working on omap devices
@ 2012-07-12 13:08 Guillaume Gardet
2012-07-13 10:09 ` Mark Brown
2012-07-26 22:00 ` Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Guillaume Gardet @ 2012-07-12 13:08 UTC (permalink / raw)
To: linux-omap
Cc: alsa-devel, peter.ujfalusi, mans.rullgard, Liam Girdwood,
Mark Brown
[-- Attachment #1: Type: text/plain, Size: 269 bytes --]
This patch add missing modules aliases to get sound working on omap devices.
Tested on Beagleboard xM rev. B.
This patch is against 3.5-rc6 vanilla.
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
Signed-off-by: Mans Rullgard <mans.rullgard@linaro.org>
[-- Attachment #2: 0001-Add-missing-modules-aliases-to-fix-audio-on-omap-dev.patch --]
[-- Type: text/x-patch, Size: 1172 bytes --]
>From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
Date: Tue, 10 Jul 2012 13:47:16 +0200
Subject: [PATCH] Add missing modules aliases to fix audio on omap devices
---
sound/soc/omap/omap-mcbsp.c | 1 +
sound/soc/omap/omap-pcm.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 1046083..acdd3ef 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -820,3 +820,4 @@ module_platform_driver(asoc_mcbsp_driver);
MODULE_AUTHOR("Jarkko Nikula <jarkko.nikula@bitmer.com>");
MODULE_DESCRIPTION("OMAP I2S SoC Interface");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-mcbsp");
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 5a649da..f0feb06 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -441,3 +441,4 @@ module_platform_driver(omap_pcm_driver);
MODULE_AUTHOR("Jarkko Nikula <jarkko.nikula@bitmer.com>");
MODULE_DESCRIPTION("OMAP PCM DMA module");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-pcm-audio");
--
1.7.7
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V2] Add missing modules aliases to get sound working on omap devices
2012-07-12 13:08 [PATCH V2] Add missing modules aliases to get sound working on omap devices Guillaume Gardet
@ 2012-07-13 10:09 ` Mark Brown
2012-07-17 13:31 ` Guillaume Gardet
2012-07-26 22:00 ` Mark Brown
1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2012-07-13 10:09 UTC (permalink / raw)
To: Guillaume Gardet
Cc: peter.ujfalusi, alsa-devel, linux-omap, mans.rullgard,
Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 623 bytes --]
On Thu, Jul 12, 2012 at 03:08:16PM +0200, Guillaume Gardet wrote:
> This patch add missing modules aliases to get sound working on omap devices.
>
> Tested on Beagleboard xM rev. B.
>
> This patch is against 3.5-rc6 vanilla.
>
> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
> Signed-off-by: Mans Rullgard <mans.rullgard@linaro.org>
>
>
> From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> Date: Tue, 10 Jul 2012 13:47:16 +0200
Please resend in the format from SubmittingPatches rather than as an
attachment.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] Add missing modules aliases to get sound working on omap devices
2012-07-13 10:09 ` Mark Brown
@ 2012-07-17 13:31 ` Guillaume Gardet
2012-07-17 13:37 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Guillaume Gardet @ 2012-07-17 13:31 UTC (permalink / raw)
To: Mark Brown
Cc: linux-omap, alsa-devel, peter.ujfalusi, mans.rullgard,
Liam Girdwood
Hi,
Le 13/07/2012 12:09, Mark Brown a écrit :
> On Thu, Jul 12, 2012 at 03:08:16PM +0200, Guillaume Gardet wrote:
>> This patch add missing modules aliases to get sound working on omap devices.
>>
>> Tested on Beagleboard xM rev. B.
>>
>> This patch is against 3.5-rc6 vanilla.
>>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
>> Signed-off-by: Mans Rullgard <mans.rullgard@linaro.org>
>>
>>
>> From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
>> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>> Date: Tue, 10 Jul 2012 13:47:16 +0200
> Please resend in the format from SubmittingPatches rather than as an
> attachment.
Ok. Please find the patch below.
This patch add missing modules aliases to get sound working on omap devices.
Tested on Beagleboard xM rev. B.
This patch is against 3.5-rc6 vanilla.
Signed-off-by: Guillaume GARDET <guillaume.gardet@free.fr>
Signed-off-by: Mans Rullgard <mans.rullgard@linaro.org>
From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
Date: Tue, 10 Jul 2012 13:47:16 +0200
Subject: [PATCH] Add missing modules aliases to fix audio on omap devices
---
sound/soc/omap/omap-mcbsp.c | 1 +
sound/soc/omap/omap-pcm.c | 1 +
2 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c
index 1046083..acdd3ef 100644
--- a/sound/soc/omap/omap-mcbsp.c
+++ b/sound/soc/omap/omap-mcbsp.c
@@ -820,3 +820,4 @@ module_platform_driver(asoc_mcbsp_driver);
MODULE_AUTHOR("Jarkko Nikula <jarkko.nikula@bitmer.com>");
MODULE_DESCRIPTION("OMAP I2S SoC Interface");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-mcbsp");
diff --git a/sound/soc/omap/omap-pcm.c b/sound/soc/omap/omap-pcm.c
index 5a649da..f0feb06 100644
--- a/sound/soc/omap/omap-pcm.c
+++ b/sound/soc/omap/omap-pcm.c
@@ -441,3 +441,4 @@ module_platform_driver(omap_pcm_driver);
MODULE_AUTHOR("Jarkko Nikula <jarkko.nikula@bitmer.com>");
MODULE_DESCRIPTION("OMAP PCM DMA module");
MODULE_LICENSE("GPL");
+MODULE_ALIAS("platform:omap-pcm-audio");
--
1.7.7
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH V2] Add missing modules aliases to get sound working on omap devices
2012-07-17 13:31 ` Guillaume Gardet
@ 2012-07-17 13:37 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2012-07-17 13:37 UTC (permalink / raw)
To: Guillaume Gardet
Cc: linux-omap, alsa-devel, peter.ujfalusi, mans.rullgard,
Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 341 bytes --]
On Tue, Jul 17, 2012 at 03:31:11PM +0200, Guillaume Gardet wrote:
> >Please resend in the format from SubmittingPatches rather than as an
> >attachment.
> Ok. Please find the patch below.
>
> This patch add missing modules aliases to get sound working on omap devices.
I'm not sure you've looked at all of SubmittingPatches...
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH V2] Add missing modules aliases to get sound working on omap devices
2012-07-12 13:08 [PATCH V2] Add missing modules aliases to get sound working on omap devices Guillaume Gardet
2012-07-13 10:09 ` Mark Brown
@ 2012-07-26 22:00 ` Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Mark Brown @ 2012-07-26 22:00 UTC (permalink / raw)
To: Guillaume Gardet
Cc: peter.ujfalusi, alsa-devel, linux-omap, mans.rullgard,
Liam Girdwood
[-- Attachment #1.1: Type: text/plain, Size: 835 bytes --]
On Thu, Jul 12, 2012 at 03:08:16PM +0200, Guillaume Gardet wrote:
> This patch add missing modules aliases to get sound working on omap devices.
So, after a bunch of hand editing I applied this. As I *repeatedly*
requested you should send patches in the format covered in
SubmittingPatches, the main reason it took me so long to get round to
applying this is that I had to strip things like this:
> From 18b1ba8becc3dd256bdaad2d825f46b551debda3 Mon Sep 17 00:00:00 2001
> From: Guillaume GARDET <guillaume.gardet@oliseo.fr>
> Date: Tue, 10 Jul 2012 13:47:16 +0200
> Subject: [PATCH] Add missing modules aliases to fix audio on omap devices
out of the commit message, plus the fact that since you hadn't used an
appropriate subject line for the subsystem your patch didn't turn up
when I searched my mail for patches to be handled.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-07-26 22:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-12 13:08 [PATCH V2] Add missing modules aliases to get sound working on omap devices Guillaume Gardet
2012-07-13 10:09 ` Mark Brown
2012-07-17 13:31 ` Guillaume Gardet
2012-07-17 13:37 ` Mark Brown
2012-07-26 22:00 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).