From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg KH Subject: Re: [PATCH v4 4/4] memory: emif: add device tree support to emif driver Date: Tue, 17 Jul 2012 09:36:02 -0700 Message-ID: <20120717163602.GA7167@kroah.com> References: <1340977407-7594-1-git-send-email-santosh.shilimkar@ti.com> <1340977407-7594-5-git-send-email-santosh.shilimkar@ti.com> <20120630042356.GC1816@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mail-gg0-f174.google.com ([209.85.161.174]:56371 "EHLO mail-gg0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752338Ab2GQQgP (ORCPT ); Tue, 17 Jul 2012 12:36:15 -0400 Received: by gglu4 with SMTP id u4so574288ggl.19 for ; Tue, 17 Jul 2012 09:36:14 -0700 (PDT) Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org, Aneesh V , tony@atomide.com On Mon, Jul 09, 2012 at 07:02:36PM +0530, Shilimkar, Santosh wrote: > Greg, > > On Mon, Jul 2, 2012 at 6:48 PM, Shilimkar, Santosh > wrote: > > On Sat, Jun 30, 2012 at 10:12 AM, Shilimkar, Santosh > > wrote: > >> On Sat, Jun 30, 2012 at 9:53 AM, Greg KH wrote: > >>> On Sat, Jun 30, 2012 at 09:38:41AM +0530, Shilimkar, Santosh wrote: > >>>> (+ Greg, By mistake the your name got dropped cc from list) > >>>> > >>>> On Fri, Jun 29, 2012 at 7:13 PM, Santosh Shilimkar > >>>> wrote: > >>>> > From: Aneesh V > >>>> > > >>>> > Device tree support for the EMIF driver. > >>>> > > >>>> > Reviewed-by: Benoit Cousson > >>>> > Reviewed-by: Grant Likely > >>>> > Tested-by: Lokesh Vutla > >>>> > Signed-off-by: Aneesh V > >>>> > [santosh.shilimkar@ti.com: Rebased against 3.5-rc] > >>>> > Signed-off-by: Santosh Shilimkar > >>>> > --- > >>>> > drivers/memory/emif.c | 291 ++++++++++++++++++++++++++++++++++++++++++++++++- > >>>> > 1 file changed, 290 insertions(+), 1 deletion(-) > >>> > >>> Wouldn't this just be better off as a separate file that only gets build > >>> if CONFIG_OF is set, as I'm sure that other systems are going to want > >>> access to these "read the device tree values" functions, right? > >>> > >> Probably yes. At least separate the LPDDR2 memory > >> generic parameter DT read code. There are parameters like phy > >> type which is specific to OMAP controllers so that still need to kept > >> inside EMIF driver. So there in driver, few lines of code will be there > >> under CONFIG_OF. > >> > >> I can extract those functions which can be commonly used and put them > >> in another file under drivers/memory/ > >> > >> Is that fine with you ? > >> > > To elaborate more, I have created below patch. > > Let me know what do you think ? > > > Any comments ?? Becides the obvious one of sending a line-wrapped patch that can not be applied? :) greg k-h