public inbox for linux-omap@vger.kernel.org
 help / color / mirror / Atom feed
From: Felipe Balbi <balbi@ti.com>
To: Ruslan Bilovol <ruslan.bilovol@ti.com>
Cc: balbi@ti.com, tony@atomide.com, ajay.gupta@ti.com,
	gadiyar@ti.com, linux-usb@vger.kernel.org,
	linux-omap@vger.kernel.org,
	Keshava Munegowda <keshava_mgowda@ti.com>
Subject: Re: [PATCH] omap: usb: host: remove deprecated flag 'es2_compatibility'
Date: Wed, 25 Jul 2012 10:54:13 +0300	[thread overview]
Message-ID: <20120725075413.GS3630@arwen.pp.htv.fi> (raw)
In-Reply-To: <1343153320-4628-1-git-send-email-ruslan.bilovol@ti.com>

[-- Attachment #1: Type: text/plain, Size: 1753 bytes --]

Hi,

On Tue, Jul 24, 2012 at 09:08:40PM +0300, Ruslan Bilovol wrote:
> Currently this flag is not used anywhere and may be safely removed.
> 
> Signed-off-by: Ruslan Bilovol <ruslan.bilovol@ti.com>

looks good to me. Keshava ?

> ---
>  arch/arm/mach-omap2/usb-host.c        |    1 -
>  arch/arm/plat-omap/include/plat/usb.h |    4 ----
>  2 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/usb-host.c b/arch/arm/mach-omap2/usb-host.c
> index dde8a11..5e1cb53 100644
> --- a/arch/arm/mach-omap2/usb-host.c
> +++ b/arch/arm/mach-omap2/usb-host.c
> @@ -500,7 +500,6 @@ void __init usbhs_init(const struct usbhs_omap_board_data *pdata)
>  		ehci_data.regulator[i] = pdata->regulator[i];
>  	}
>  	ehci_data.phy_reset = pdata->phy_reset;
> -	ohci_data.es2_compatibility = pdata->es2_compatibility;
>  	usbhs_data.ehci_data = &ehci_data;
>  	usbhs_data.ohci_data = &ohci_data;
>  
> diff --git a/arch/arm/plat-omap/include/plat/usb.h b/arch/arm/plat-omap/include/plat/usb.h
> index 762eeb0..f8c1eb8 100644
> --- a/arch/arm/plat-omap/include/plat/usb.h
> +++ b/arch/arm/plat-omap/include/plat/usb.h
> @@ -32,9 +32,6 @@ struct usbhs_omap_board_data {
>  	/* have to be valid if phy_reset is true and portx is in phy mode */
>  	int	reset_gpio_port[OMAP3_HS_USB_PORTS];
>  
> -	/* Set this to true for ES2.x silicon */
> -	unsigned			es2_compatibility:1;
> -
>  	unsigned			phy_reset:1;
>  
>  	/*
> @@ -53,7 +50,6 @@ struct ehci_hcd_omap_platform_data {
>  
>  struct ohci_hcd_omap_platform_data {
>  	enum usbhs_omap_port_mode	port_mode[OMAP3_HS_USB_PORTS];
> -	unsigned			es2_compatibility:1;
>  };
>  
>  struct usbhs_omap_platform_data {
> -- 
> 1.7.1
> 

-- 
balbi

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2012-07-25  7:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-24 18:08 [PATCH] omap: usb: host: remove deprecated flag 'es2_compatibility' Ruslan Bilovol
2012-07-25  7:54 ` Felipe Balbi [this message]
2012-07-25 12:34   ` Munegowda, Keshava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120725075413.GS3630@arwen.pp.htv.fi \
    --to=balbi@ti.com \
    --cc=ajay.gupta@ti.com \
    --cc=gadiyar@ti.com \
    --cc=keshava_mgowda@ti.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=ruslan.bilovol@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox