From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: linux-omap@vger.kernel.org, "Liam Girdwood" <lrg@ti.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: New build warnings
Date: Mon, 30 Jul 2012 18:40:43 +0100 [thread overview]
Message-ID: <20120730174043.GO4468@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120730164444.GO6802@n2100.arm.linux.org.uk>
On Mon, Jul 30, 2012 at 05:44:44PM +0100, Russell King - ARM Linux wrote:
> -#define TWLRES_OF_MATCH(comp, label) TWL_OF_MATCH(comp, TWLRES, label)
> - TWLRES_OF_MATCH("ti,twl6030-clk32kg", CLK32KG),
> but completely forgets that this:
> TWL6030_FIXED_RESOURCE(CLK32KG, 0x8C, 0);
> defines a structure that it was using. (Welcome to why macros are horrid
> when they hide the names of stuff they create.)
I actually have the fix in a separate patch which completely removes
the "regulator" but wasn't happy about pushing the patch for 3.6 since I
can't test (I don't think anyone's ever actually used those and
obviously they should be using the clk API now).
next prev parent reply other threads:[~2012-07-30 17:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 16:44 New build warnings Russell King - ARM Linux
2012-07-30 17:40 ` Mark Brown [this message]
2012-07-30 18:06 ` Russell King - ARM Linux
2012-07-30 18:40 ` Mark Brown
2012-09-08 8:38 ` Russell King - ARM Linux
2012-09-09 19:12 ` Uwe Kleine-König
2012-09-09 23:33 ` Mark Brown
2012-09-10 6:40 ` Uwe Kleine-König
2012-09-10 6:42 ` Mark Brown
2012-09-10 7:05 ` Uwe Kleine-König
2012-09-10 7:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120730174043.GO4468@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).