From: Matthias Kaehlcke <matthias@kaehlcke.net>
To: "AnilKumar, Chimata" <anilkumar@ti.com>
Cc: Richard Purdie <rpurdie@rpsys.net>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3] backlight: Add TPS65217 WLED driver
Date: Thu, 23 Aug 2012 12:25:36 +0200 [thread overview]
Message-ID: <20120823102536.GA27787@darwin> (raw)
In-Reply-To: <331ABD5ECB02734CA317220B2BBEABC13EA1E90E@DBDE01.ent.ti.com>
Hi AnilKumar,
thanks for your comments
El Thu, Aug 23, 2012 at 07:53:49AM +0000 AnilKumar, Chimata ha dit:
> This patch should divide into 2 patches, one patch meant for
> MFD changes other for backlight.
will do
> > +struct tps65217_bl {
> > + struct tps65217 *tps;
> > + struct device *dev;
> > + struct backlight_device *bl;
> > + int on;
>
> Can you use Boolean here? Change the name as well, something
> like bool is_enabled?
ok
> > + pdata->fdim = TPS65217_BL_FDIM_200HZ;
>
> Why 200 by default?
it's the default value in the register after reset
best regards
--
Matthias Kaehlcke
Embedded Linux Developer
Amsterdam
If you don't know where you are going,
you will probably end up somewhere else
(Laurence J. Peter)
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-
next prev parent reply other threads:[~2012-08-23 10:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-22 21:04 [PATCH v3] backlight: Add TPS65217 WLED driver Matthias Kaehlcke
2012-08-23 7:53 ` AnilKumar, Chimata
2012-08-23 10:25 ` Matthias Kaehlcke [this message]
2012-08-24 9:27 ` Koen Kooi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120823102536.GA27787@darwin \
--to=matthias@kaehlcke.net \
--cc=anilkumar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=rpurdie@rpsys.net \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox