From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Arnd Bergmann <arnd@arndb.de>
Subject: Re: New build warnings
Date: Mon, 10 Sep 2012 07:33:34 +0800 [thread overview]
Message-ID: <20120909233333.GA15911@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20120909191240.GV28643@pengutronix.de>
On Sun, Sep 09, 2012 at 09:12:40PM +0200, Uwe Kleine-König wrote:
> On Sat, Sep 08, 2012 at 09:38:49AM +0100, Russell King - ARM Linux wrote:
> > > of: add const to struct *of_device_id.data
> > >
> > > Drivers should never need to modify the data of a device id. So it can
> > > be const which in turn allows more consts in the driver.
> > I notice this one is still present in the kernel. Uwe, what's happening
> > with it?
> Yeah, the warning was introduced by my patch. It's not trivial to fix
> because the twl-regulator driver modifies the data used to probe devices
> during probe. That is the result of two probes might depend on their
> order. I mentioned that problem in the cover letter of my series but got
> no feedback from someone feeling responsible for this driver.
> Arnd sent a patch for that problem, don't know its state though.
I don't recall such a patch being sent to me. The twl-regulator driver
is unmaintained so it's unlikely anyone is going to actively work on it.
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-09 23:33 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-30 16:44 New build warnings Russell King - ARM Linux
2012-07-30 17:40 ` Mark Brown
2012-07-30 18:06 ` Russell King - ARM Linux
2012-07-30 18:40 ` Mark Brown
2012-09-08 8:38 ` Russell King - ARM Linux
2012-09-09 19:12 ` Uwe Kleine-König
2012-09-09 23:33 ` Mark Brown [this message]
2012-09-10 6:40 ` Uwe Kleine-König
2012-09-10 6:42 ` Mark Brown
2012-09-10 7:05 ` Uwe Kleine-König
2012-09-10 7:43 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120909233333.GA15911@opensource.wolfsonmicro.com \
--to=broonie@opensource.wolfsonmicro.com \
--cc=arnd@arndb.de \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).