From: Tony Lindgren <tony@atomide.com>
To: "Munegowda, Keshava" <keshava_mgowda@ti.com>
Cc: Ruslan Bilovol <ruslan.bilovol@ti.com>,
linux@arm.linux.org.uk, b-cousson@ti.com, paul@pwsan.com,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP2+: mux: add support for PAD wakeup event handler
Date: Tue, 11 Sep 2012 09:27:25 -0700 [thread overview]
Message-ID: <20120911162724.GB23092@atomide.com> (raw)
In-Reply-To: <CAP05o4+sjt7JERPFN1i3kHswOwDL2rVvQcwTMQPBaJPMUXr86Q@mail.gmail.com>
* Munegowda, Keshava <keshava_mgowda@ti.com> [120911 00:43]:
> On Tue, Sep 11, 2012 at 12:09 AM, Tony Lindgren <tony@atomide.com> wrote:
> > * Ruslan Bilovol <ruslan.bilovol@ti.com> [120910 03:39]:
> >> OMAP mux now parses active wakeup events from pad registers and calls
> >> corresponding handler, if handler is not registered - corresponding
> >> hwmod ISRs once a wakeup is detected.
> >> This is useful for cases when routing wakeups to corresponding hwmod
> >> ISRs complicates those ISRs handlers (for example, ISR handler may
> >> not know who the interrupt source is)
> >
> > The mux code in arch/arm/mach-omap2 will be going away and replaced
> > by device tree based pinctrl-single.
>
> Thanks tony
> when is this device tree based pinctrl-single will be available
> in mainline?
It is already merged during v3.6 merge window, please see:
drivers/pinctrl/pinctrl-single.c
Documentation/devicetree/bindings/pinctrl/pinctrl-single.txt
For omap-serial, see the patch "serial: omap: Request pins using pinctrl
framework" in tty-next.
Then for setting up wake-up events, you can define alternative
named states, such as:
default: driver specific static pins that only get set once during the probe
active: subset of driver specific dynamic pins that are remuxed for runtime
idle: subset of driver specific dynamic pins that are remuxed for idle
Then just in the pinctrl using driver probe do:
foo->pins = pinctrl_get_select_default(&pdev->dev);
...
foo->pins_active = pinctrl_lookup_state(foo->pins, "active");
...
foo->pins_idle = pinctrl_lookup_state(foo->pins, PINCTRL_STATE_IDLE);
...
And then you can toggle the pin settings in foo_runtime_suspend and
resume:
if (foo->pins_idle) {
int res;
res = pinctrl_select_state(foo->pins, foo->pins_idle);
...
}
I don't think we have anything available for handling the wake-up
events yet in the pinctrl framework, but that should be added in
a Linux generic way to pinctrl framework so drivers can set up
their wake-up handles. That we we don't end up patching a custom
framework that's going away.
Regards,
Tony
prev parent reply other threads:[~2012-09-11 16:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 10:38 [PATCH] ARM: OMAP2+: mux: add support for PAD wakeup event handler Ruslan Bilovol
2012-09-10 10:51 ` Munegowda, Keshava
2012-09-10 18:39 ` Tony Lindgren
2012-09-11 7:42 ` Munegowda, Keshava
2012-09-11 16:27 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120911162724.GB23092@atomide.com \
--to=tony@atomide.com \
--cc=b-cousson@ti.com \
--cc=keshava_mgowda@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=paul@pwsan.com \
--cc=ruslan.bilovol@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox