From mboxrd@z Thu Jan 1 00:00:00 1970 From: Catalin Marinas Subject: Re: [RFC PATCH] ARM: mm: ADD descriptor string to CONFIG_DMA_ADDR_64BIT_T Date: Wed, 12 Sep 2012 14:19:18 +0100 Message-ID: <20120912131918.GD21823@arm.com> References: <1347429006-10879-1-git-send-email-r.sricharan@ti.com> <5050841A.7030203@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from cam-admin0.cambridge.arm.com ([217.140.96.50]:36262 "EHLO cam-admin0.cambridge.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754924Ab2ILNUb (ORCPT ); Wed, 12 Sep 2012 09:20:31 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: Cyril Chemparathy , R Sricharan , "linux-arm-kernel@lists.infradead.org" , "linux-omap@vger.kernel.org" On Wed, Sep 12, 2012 at 01:57:26PM +0100, Shilimkar, Santosh wrote: > On Wed, Sep 12, 2012 at 6:16 PM, Cyril Chemparathy wrote: > > > > On 9/12/2012 1:50 AM, R Sricharan wrote: > >> > >> Even if CONFIG_DMA_ADDR_64BIT_T is enabled by the defconfig, > >> the feature is not getting selected. > >> Adding a string description in the Kconfig resolves this. > >> > >> But not sure if this is the right way to fix this. > >> > > > > Shouldn't you be selecting this in your 64-bit dma address capable arch > > instead? > > > Yes. The selection to enable CONFIG_DMA_ADDR_64BIT_T happens > in the arch which needs it. Since this option was made as simple bool, > looks like because of some KCONFIG magic, it was not getting selected. > Adding some help text does fix the issue and thats is the patch all about. Are you sure you select this explicitly in Kconfig? It should not depend on a description. What I understood from the initial email was that this option was only added to the defconfig but ignored by the kernel as it's not a user selectable option (unless you add some text). -- Catalin