From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Valentin, Eduardo" <eduardo.valentin@ti.com>
Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
b-cousson@ti.com, j-keerthy@ti.com, linux-kernel@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings
Date: Wed, 12 Sep 2012 17:18:16 +0300 [thread overview]
Message-ID: <20120912141816.GK19410@mwanda> (raw)
In-Reply-To: <CAGF5oy8kyMOO+0kxHO054LKxEh5jkUQGUuUM4OF0ncQV4x8uxQ@mail.gmail.com>
On Wed, Sep 12, 2012 at 12:19:00PM +0300, Valentin, Eduardo wrote:
> Hello Dan,
>
> On Wed, Sep 12, 2012 at 11:26 AM, Dan Carpenter
> <dan.carpenter@oracle.com> wrote:
> > On Wed, Sep 12, 2012 at 11:11:27AM +0300, Dan Carpenter wrote:
> >> On Tue, Sep 11, 2012 at 07:06:52PM +0300, Eduardo Valentin wrote:
> >> > From: J Keerthy <j-keerthy@ti.com>
> >> >
> >> > Removes checkpatch warnings on omap-bandgap.c.
> >> >
> >>
> >> Which checkpatch.pl warnings?
> >>
> >> > + omap_bandgap_writel(bg_ptr,
> >> > + rval->tshut_threshold,
> >> > + tsr->tshut_threshold);
> >>
> >> That's just whacky.
> >>
> >> Personally, I've never cared much about long lines, so I'd prefer
> >> to leave these as is until someone can break the functions up and
> >> remove them in a proper way instead of just shifting everything
> >> randomly to the left.
> >>
> >
> > Sorry, that was my default response without looking at the code.
> >
> > This is already broken up into small functions pretty nicely. You
> > might want to consider using shorter names. For example
> > omap_bandgap_writel() could be changed to "obg_writel()" and "bg_ptr"
> > could be changed to just "bg" because it's obviously a pointer.
>
> Yeah, that's one option. Of course the deal is to find the proper
> balance between cryptic symbol names and code mangled / shifted to the
> left.
>
Another option would be to just let checkpatch complain. It's a
perl script, not the king of us. Do what looks the nicest to human
beings.
regards,
dan carpenter
next prev parent reply other threads:[~2012-09-12 14:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 16:06 [PATCH 0/4] staging: omap-thermal: clean-ups and fixes Eduardo Valentin
2012-09-11 16:06 ` [PATCH 1/4] staging: omap-thermal: Correct checkpatch.pl warnings Eduardo Valentin
2012-09-12 8:11 ` Dan Carpenter
2012-09-12 8:26 ` Dan Carpenter
2012-09-12 9:19 ` Valentin, Eduardo
2012-09-12 14:18 ` Dan Carpenter [this message]
2012-09-11 16:06 ` [PATCH 2/4] staging: omap-thermal: remove checkpatch.pl warnings on data files Eduardo Valentin
2012-09-11 16:06 ` [PATCH 3/4] staging: omap-thermal: fix polling period settings Eduardo Valentin
2012-09-11 16:06 ` [PATCH 4/4] staging: omap-thermal: improve conf data handling and initialization Eduardo Valentin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120912141816.GK19410@mwanda \
--to=dan.carpenter@oracle.com \
--cc=b-cousson@ti.com \
--cc=devel@driverdev.osuosl.org \
--cc=eduardo.valentin@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).