From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Rob Clark <rob.clark@linaro.org>
Cc: dri-devel@lists.freedesktop.org, linux-omap@vger.kernel.org,
patches@linaro.org, Greg KH <greg@kroah.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Andy Gross <andy.gross@ti.com>, Rob Clark <rob@ti.com>
Subject: Re: [PATCH 1/2] drm: support for rotated scanout
Date: Mon, 17 Sep 2012 20:33:33 +0300 [thread overview]
Message-ID: <20120917173333.GK19732@intel.com> (raw)
In-Reply-To: <1346776556-13098-1-git-send-email-rob.clark@linaro.org>
On Tue, Sep 04, 2012 at 11:35:56AM -0500, Rob Clark wrote:
> From: Rob Clark <rob@ti.com>
>
> For drivers that can support rotated scanout, the extra parameter
> checking in drm-core, while nice, tends to get confused. To solve
> this drivers can set the crtc or plane invert_dimensions field so
> that the dimension checking takes into account the rotation that
> the driver is performing.
>
> v1: original
> v2: remove invert_dimensions from plane, at Ville's suggestion.
> Userspace can give rotated src coordinates, so invert_dimensions
> is not required for planes.
>
> Signed-off-by: Rob Clark <rob@ti.com>
Sorry for the delay Rob, I somehow missed this. In any case, the patch
looks OK to me.
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel OTC
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2012-09-17 17:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-04 16:35 [PATCH 1/2] drm: support for rotated scanout Rob Clark
2012-09-17 17:33 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120917173333.GK19732@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=andy.gross@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=greg@kroah.com \
--cc=linux-omap@vger.kernel.org \
--cc=patches@linaro.org \
--cc=rob.clark@linaro.org \
--cc=rob@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).