From: Matt Porter <mporter@ti.com>
To: Rob Herring <robherring2@gmail.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Jon Hunter <jon-hunter@ti.com>,
device-tree <devicetree-discuss@lists.ozlabs.org>,
linux-omap <linux-omap@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Benoit Cousson <b-cousson@ti.com>,
Stephen Warren <swarren@nvidia.com>,
Grant Likely <grant.likely@secretlab.ca>,
Russell King <linux@arm.linux.org.uk>,
Vinod Koul <vinod.koul@intel.com>, Dan Williams <djbw@fb.com>
Subject: Re: [PATCH V6 1/2] of: Add generic device tree DMA helpers
Date: Wed, 19 Sep 2012 10:40:40 -0400 [thread overview]
Message-ID: <20120919144040.GC16522@beef> (raw)
In-Reply-To: <5059D874.6040107@gmail.com>
On Wed, Sep 19, 2012 at 09:36:36AM -0500, Rob Herring wrote:
> On 09/19/2012 09:24 AM, Arnd Bergmann wrote:
> > On Wednesday 19 September 2012, Matt Porter wrote:
> >>> +Optional properties:
> >>> +- #dma-channels: Number of DMA channels supported by the controller.
> >>> +- #dma-requests: Number of DMA requests signals supported by the
> >>> + controller.
> >>
> >> Shouldn't these two optional properties drop the prefix #? By
> >> convention adopted from the various original OF/ePAPR/etc specs, the
> >> only properties I would expect to see with this prefix are the
> >> "*-cells" cell sizes. A quick search indicates this is the case
> >> throughout all the current bindings.
> >
> > I always assumed that the # prefix is used to indicate that we are counting
> > things instead of listing them.
>
> Lots of properties count things, but don't have a #. nr_gpios or spi
> chipselect counts for example. I'd say drop the #.
Ok, I can drop another trivial patch since I hear Jon is on vacation.
Yeah, I grepped all the bindings and it's only ever encountered on cell
sizes. There's not even one example of it used as above.
-Matt
next prev parent reply other threads:[~2012-09-19 14:39 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 22:41 [PATCH V6 0/2] of: Add generic device tree DMA helpers Jon Hunter
2012-09-14 22:41 ` [PATCH V6 1/2] " Jon Hunter
2012-09-14 22:46 ` Stephen Warren
2012-09-15 0:14 ` Russell King - ARM Linux
[not found] ` <20120915001431.GB12445-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-09-17 20:42 ` Arnd Bergmann
[not found] ` <201209172042.11860.arnd-r2nGTMty4D4@public.gmane.org>
2012-09-17 23:06 ` David Brown
[not found] ` <20120917230615.GA26502-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2012-09-18 12:50 ` Arnd Bergmann
2012-09-18 22:19 ` Mitch Bradley
[not found] ` <5058F35A.8040702-D5eQfiDGL7eakBO8gow8eQ@public.gmane.org>
2012-09-18 22:32 ` Russell King - ARM Linux
2012-09-19 11:09 ` Arnd Bergmann
[not found] ` <201209191109.16529.arnd-r2nGTMty4D4@public.gmane.org>
2012-09-19 14:40 ` Mitch Bradley
2012-09-19 13:52 ` Matt Porter
2012-09-19 14:07 ` Matt Porter
2012-09-19 14:24 ` Arnd Bergmann
2012-09-19 14:36 ` Rob Herring
2012-09-19 14:40 ` Matt Porter [this message]
2012-09-19 14:50 ` Arnd Bergmann
2012-09-19 21:25 ` Mitch Bradley
2012-09-19 14:10 ` Rob Herring
[not found] ` <1347662517-4210-1-git-send-email-jon-hunter-l0cyMroinI0@public.gmane.org>
2012-09-14 22:41 ` [PATCH V6 2/2] dmaengine: add helper function to request a slave DMA channel Jon Hunter
2012-09-17 3:33 ` Vinod Koul
2012-09-17 11:59 ` Arnd Bergmann
2012-09-17 22:36 ` Russell King - ARM Linux
2012-09-18 3:13 ` Vinod Koul
2012-09-18 13:21 ` Matt Porter
2012-09-18 15:20 ` Arnd Bergmann
2012-09-18 18:10 ` Russell King - ARM Linux
2012-09-24 22:25 ` Jon Hunter
2012-09-25 4:35 ` Vinod Koul
2012-10-16 2:43 ` Shawn Guo
2012-10-16 2:39 ` Vinod Koul
2012-11-09 20:01 ` Jon Hunter
2012-11-16 1:37 ` Vinod Koul
2012-11-16 8:39 ` Nicolas Ferre
2012-11-16 15:45 ` Jon Hunter
2012-11-28 17:06 ` Vinod Koul
2012-12-19 17:12 ` Jon Hunter
2012-12-20 14:57 ` Vinod Koul
2012-09-18 3:00 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120919144040.GC16522@beef \
--to=mporter@ti.com \
--cc=arnd@arndb.de \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=djbw@fb.com \
--cc=grant.likely@secretlab.ca \
--cc=jon-hunter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=nicolas.ferre@atmel.com \
--cc=robherring2@gmail.com \
--cc=swarren@nvidia.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).