From: Tony Lindgren <tony@atomide.com>
To: Selso LIBERADO <sli@cioinfoindus.fr>
Cc: linux-omap@vger.kernel.org
Subject: Re: tidspbridge build fails
Date: Mon, 24 Sep 2012 10:00:54 -0700 [thread overview]
Message-ID: <20120924170054.GE28835@atomide.com> (raw)
In-Reply-To: <loom.20120924T183345-467@post.gmane.org>
* Selso LIBERADO <sli@cioinfoindus.fr> [120924 09:46]:
> Joni Lapilainen <joni.lapilainen <at> gmail.com> writes:
>
> >
> > Building tidspbridge fails:
> >
> > CC [M] drivers/staging/tidspbridge/core/tiomap3430.o
> > drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start':
> > drivers/staging/tidspbridge/core/tiomap3430.c:421:25: error:
> > 'OMAP343X_CTRL_BASE' undeclared (first use in this function)
> > drivers/staging/tidspbridge/core/tiomap3430.c:421:25: note: each
> > undeclared identifier is reported only once for each function it
> > appears in
> > make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo <at> vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> >
>
> This definition has moved to : arch/arm/mach-omap2/omap34xx.h
> I don't know if we can include directly this file in tiomap3430.c (I'm newbie)
No we should not, that should be private to arch/arm/mach-omap2.
> However there is still the symbole OMAP34XX_WDT3_BASE in
> 'drivers/staging/tidspbridge/core/wdt.c' that is not resolved.
OK it's probably best to define that locally there or in some
drivers/staging/tidispbridge header whatever the code is doing
with it.. Care to do a patch for it?
Regards,
Tony
next prev parent reply other threads:[~2012-09-24 17:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-22 1:46 tidspbridge build fails Joni Lapilainen
2012-09-23 21:16 ` Tony Lindgren
2012-09-24 16:37 ` Selso LIBERADO
2012-09-24 17:00 ` Tony Lindgren [this message]
2012-09-24 18:56 ` Selso LIBERADO
2012-09-24 21:04 ` Tony Lindgren
2012-09-24 22:13 ` Omar Ramirez Luna
2012-09-25 17:39 ` Selso LIBERADO
2012-09-26 0:35 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924170054.GE28835@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=sli@cioinfoindus.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).