tidspbridge build fails

tidspbridge build fails

[Joni Lapilainen]

Building tidspbridge fails:

  CC [M]  drivers/staging/tidspbridge/core/tiomap3430.o
drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start':
drivers/staging/tidspbridge/core/tiomap3430.c:421:25: error:
'OMAP343X_CTRL_BASE' undeclared (first use in this function)
drivers/staging/tidspbridge/core/tiomap3430.c:421:25: note: each
undeclared identifier is reported only once for each function it
appears in
make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1

Re: tidspbridge build fails

[Tony Lindgren]

* Joni Lapilainen <joni.lapilainen@gmail.com> [120921 18:47]:
> Building tidspbridge fails:
> 
>   CC [M]  drivers/staging/tidspbridge/core/tiomap3430.o
> drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start':
> drivers/staging/tidspbridge/core/tiomap3430.c:421:25: error:
> 'OMAP343X_CTRL_BASE' undeclared (first use in this function)
> drivers/staging/tidspbridge/core/tiomap3430.c:421:25: note: each
> undeclared identifier is reported only once for each function it
> appears in
> make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1

Hmm I think a fix for that is already queued by Greg and it
seems we don't have it in linux-omap master any longer as
I dropped it after Greg picked it up.

Does commit c37a1747 (staging: tidspbridge: Prepare for irqs.h removal)
in linux next solve the problem for you?

Regards,

Tony

Re: tidspbridge build fails

[Selso LIBERADO]

Joni Lapilainen <joni.lapilainen <at> gmail.com> writes:

> 
> Building tidspbridge fails:
> 
>   CC [M]  drivers/staging/tidspbridge/core/tiomap3430.o
> drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start':
> drivers/staging/tidspbridge/core/tiomap3430.c:421:25: error:
> 'OMAP343X_CTRL_BASE' undeclared (first use in this function)
> drivers/staging/tidspbridge/core/tiomap3430.c:421:25: note: each
> undeclared identifier is reported only once for each function it
> appears in
> make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo <at> vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

This definition has moved to : arch/arm/mach-omap2/omap34xx.h
I don't know if we can include directly this file in tiomap3430.c (I'm newbie)

However there is still the symbole  OMAP34XX_WDT3_BASE in
'drivers/staging/tidspbridge/core/wdt.c' that is not resolved.

Re: tidspbridge build fails

[Tony Lindgren]

* Selso LIBERADO <sli@cioinfoindus.fr> [120924 09:46]:
> Joni Lapilainen <joni.lapilainen <at> gmail.com> writes:
> 
> > 
> > Building tidspbridge fails:
> > 
> >   CC [M]  drivers/staging/tidspbridge/core/tiomap3430.o
> > drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start':
> > drivers/staging/tidspbridge/core/tiomap3430.c:421:25: error:
> > 'OMAP343X_CTRL_BASE' undeclared (first use in this function)
> > drivers/staging/tidspbridge/core/tiomap3430.c:421:25: note: each
> > undeclared identifier is reported only once for each function it
> > appears in
> > make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> > the body of a message to majordomo <at> vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 
> 
> This definition has moved to : arch/arm/mach-omap2/omap34xx.h
> I don't know if we can include directly this file in tiomap3430.c (I'm newbie)

No we should not, that should be private to arch/arm/mach-omap2.
 
> However there is still the symbole  OMAP34XX_WDT3_BASE in
> 'drivers/staging/tidspbridge/core/wdt.c' that is not resolved.

OK it's probably best to define that locally there or in some
drivers/staging/tidispbridge header whatever the code is doing
with it.. Care to do a patch for it? 

Regards,

Tony

Re: tidspbridge build fails

[Selso LIBERADO]

Tony Lindgren <tony <at> atomide.com> writes:
...
> 
OK. I sent it.

Re: tidspbridge build fails

[Tony Lindgren]

* Selso LIBERADO <sli@cioinfoindus.fr> [120924 11:58]:
> Tony Lindgren <tony <at> atomide.com> writes:
> ...
> > 
> OK. I sent it.

OK thanks!

Tony

Re: tidspbridge build fails

[Omar Ramirez Luna]

Hi,

On Mon, Sep 24, 2012 at 11:37 AM, Selso LIBERADO <sli@cioinfoindus.fr> wrote:
...
>>   CC [M]  drivers/staging/tidspbridge/core/tiomap3430.o
>> drivers/staging/tidspbridge/core/tiomap3430.c: In function 'bridge_brd_start':
>> drivers/staging/tidspbridge/core/tiomap3430.c:421:25: error:
>> 'OMAP343X_CTRL_BASE' undeclared (first use in this function)
>> drivers/staging/tidspbridge/core/tiomap3430.c:421:25: note: each
>> undeclared identifier is reported only once for each function it
>> appears in
>> make[3]: *** [drivers/staging/tidspbridge/core/tiomap3430.o] Error 1
...
> This definition has moved to : arch/arm/mach-omap2/omap34xx.h
> I don't know if we can include directly this file in tiomap3430.c (I'm newbie)
>
> However there is still the symbole  OMAP34XX_WDT3_BASE in
> 'drivers/staging/tidspbridge/core/wdt.c' that is not resolved.

This should be solved by Tony's patch:

https://patchwork.kernel.org/patch/1435311/

Right now it is on staging-next.

Regards,

Omar

Re: tidspbridge build fails

[Selso LIBERADO]

Hi !

Here what's happening when applying the patch : 

sli@SLI-V420:~/developpement/INTERNE/BEAGLEBOARD/logiciel/linux-omap$ git apply
--check ../../archive/10-17-staging-tidspbridge-Prepare-for-irqs.h-removal.patch
error: patch failed: drivers/staging/tidspbridge/core/wdt.c:25
error: drivers/staging/tidspbridge/core/wdt.c: patch does not apply

newbie question : Where is the staging-next rep ?

Re: tidspbridge build fails

[Omar Ramirez Luna]

Hi,

On Tue, Sep 25, 2012 at 12:39 PM, Selso LIBERADO <sli@cioinfoindus.fr> wrote:
> Hi !
>
> Here what's happening when applying the patch :
>
> sli@SLI-V420:~/developpement/INTERNE/BEAGLEBOARD/logiciel/linux-omap$ git apply
> --check ../../archive/10-17-staging-tidspbridge-Prepare-for-irqs.h-removal.patch
> error: patch failed: drivers/staging/tidspbridge/core/wdt.c:25
> error: drivers/staging/tidspbridge/core/wdt.c: patch does not apply

Yes, got the same had to rework the patch to apply.

If you have the time, you could try:

git am --3way <patch>

Then resolve the conflicts[1].

> newbie question : Where is the staging-next rep ?

http://git.kernel.org/?p=linux/kernel/git/gregkh/staging.git;a=summary

Regards,

Omar

---
[1] http://www.kernel.org/pub/software/scm/git/docs/v1.7.3/user-manual.html#resolving-a-merge