From: Samuel Ortiz <sameo@linux.intel.com>
To: Matthias Kaehlcke <matthias@kaehlcke.net>
Cc: "AnilKumar, Chimata" <anilkumar@ti.com>,
Richard Purdie <rpurdie@rpsys.net>,
"Koen Kooi <koen@dominion.thruhere.net>,
linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v4 1/2] backlight: Add TPS65217 WLED driver
Date: Mon, 24 Sep 2012 23:58:05 +0200 [thread overview]
Message-ID: <20120924215805.GH28670@sortiz-mobl> (raw)
In-Reply-To: <20120924202528.GE26600@darwin>
Hi Matthias,
On Mon, Sep 24, 2012 at 10:25:28PM +0200, Matthias Kaehlcke wrote:
> The TPS65217 chip contains a boost converter and current sinks which can be
> used to drive LEDs for use as backlights. Expose this functionality via the
> backlight API.
>
> Tested on an AM335x based custom board with a single WLED string, using
> different values for ISEL and FDIM (though it would be hard to tell the
> difference except for the value in WLEDCTRL1). Both instantiation through the
> device tree and by passing platform data have been tested. Testing has been
> done with an Androidized 3.2 kernel from the rowboat project. Koen Kooi
> reported the driver to be working on a Beaglebone board with LCD3 cape
>
> This patch is based on the mfd branch (20120924)
>
> Changes since v3:
>
> * split in two patches, one for the driver another for adding the mfd
> subdevice
> * renamed variable "on" to "is_enabled" and changed type to boolean
>
> Signed-off-by: Matthias Kaehlcke <matthias@kaehlcke.net>
> ---
> drivers/video/backlight/Kconfig | 7 +
> drivers/video/backlight/Makefile | 1 +
> drivers/video/backlight/tps65217_bl.c | 352 +++++++++++++++++++++++++++++++++
> include/linux/mfd/tps65217.h | 18 ++
> 4 files changed, 378 insertions(+)
> create mode 100644 drivers/video/backlight/tps65217_bl.c
Applied as well, although it could go through Richard's tree. Having his
review would be nice anyway.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-09-24 21:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 20:25 [PATCH v4 1/2] backlight: Add TPS65217 WLED driver Matthias Kaehlcke
2012-09-24 21:58 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120924215805.GH28670@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=anilkumar@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=matthias@kaehlcke.net \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).