linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>,
	Linus Walleij <linus.walleij@linaro.org>,
	Peter Ujfalusi <peter.ujfalusi@ti.com>
Subject: Re: Powering OMAP's pins
Date: Tue, 25 Sep 2012 12:07:21 -0700	[thread overview]
Message-ID: <20120925190721.GD4840@atomide.com> (raw)
In-Reply-To: <1348592700.2342.49.camel@deskari>

* Tomi Valkeinen <tomi.valkeinen@ti.com> [120925 10:06]:
> On Tue, 2012-09-25 at 08:38 -0700, Tony Lindgren wrote:
> > * Tomi Valkeinen <tomi.valkeinen@ti.com> [120925 03:22]:
> > > Hi Tony,
> > > 
> > > Each pin of OMAP requires a particular power to be enabled for the pin
> > > to function (Ball Characteristics table from data manual). Is there a
> > > plan how this is managed with pinctrl? Currently each driver needs to
> > > make sure the correct regulators are enabled for the pins it uses, which
> > > is platform specific and messy.
> > > 
> > > As a driver maintainer, I would wish that the pins would just get
> > > enabled automatically when I call pm_runtime_get()...
> > 
> > Hmm can you clarify a bit what exactly do you want to do there
> > with pm_runtime_get()? Call the regulator framework?
> 
> Well, I'm not very familiar with pinctrl, but if I've understood right,
> a set of pins are assigned to a driver in DT data (or wherever, that's
> not relevant). Those pins should be automatically configured and enabled
> when the driver uses pm_runtime_get() to enable its hardware.
> 
> And if I've also understood right, the pinctrl discussions related to
> omap have only dealt with pin muxing itself. But that's not enough to
> get the pin functional, but the relevant regulator needs to be enabled
> also.
> 
> So when I call pm_runtime_get in the omapdss driver, I imagine that the
> runtime PM and pinctrl would together handle muxing the pins for
> omapdss's use, and also enable the relevant regulators to make the pins
> usable.

But aren't these regulators something that potentially are dynamically
configured by the driver? For example, vdds_(sd)mmc1 depends on which
card is plugged in.

So to me it seesm that it's best to define the regulators and claim them
by the driver using them rather than try to use automatically. It's
sort of the same situation as with GPIO pins?

Regards,

Tony


  reply	other threads:[~2012-09-25 19:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-25 10:21 Powering OMAP's pins Tomi Valkeinen
2012-09-25 15:38 ` Tony Lindgren
2012-09-25 17:05   ` Tomi Valkeinen
2012-09-25 19:07     ` Tony Lindgren [this message]
2012-09-26  7:05       ` Tomi Valkeinen
2012-09-26 18:59         ` Tony Lindgren
2012-09-27  7:18           ` Tomi Valkeinen
2012-09-27 18:43             ` Tony Lindgren
2012-09-27 18:51               ` Tony Lindgren
2012-09-28  6:13                 ` Tomi Valkeinen
2012-09-28 14:37                   ` Tony Lindgren
2012-09-26 11:46     ` Linus Walleij
2012-09-26 12:56       ` Tomi Valkeinen
2012-09-26 13:27         ` Linus Walleij
2012-09-26 19:03           ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120925190721.GD4840@atomide.com \
    --to=tony@atomide.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=peter.ujfalusi@ti.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).