From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap Date: Fri, 28 Sep 2012 08:05:38 -0700 Message-ID: <20120928150538.GB4840@atomide.com> References: <1348839609-10456-1-git-send-email-lokeshvutla@ti.com> <1348839609-10456-3-git-send-email-lokeshvutla@ti.com> <20120928145459.GZ4840@atomide.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:16265 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1758343Ab2I1PFl (ORCPT ); Fri, 28 Sep 2012 11:05:41 -0400 Content-Disposition: inline In-Reply-To: Sender: linux-omap-owner@vger.kernel.org List-Id: linux-omap@vger.kernel.org To: "Shilimkar, Santosh" Cc: Lokesh Vutla , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org * Shilimkar, Santosh [120928 08:02]: > On Fri, Sep 28, 2012 at 8:25 PM, Tony Lindgren wrote: > > > > * Lokesh Vutla [120928 06:41]: > > > Move plat/dma.h header to platform_data/dma-omap.h as > > > part of the single zImage work. > > > > Hmm there's no platform data in this header, just > > exported things for drivers to use. So it should not > > be placed into platform_data. > > > > Maybe it should be #include for now? > > > I wasn't sure either when the file was placed under platform-data. > I agree for now we can keep it mach layer but than means OMAP1 and > OMAP2+ DMA header and source code needs to be split. That > is not so straight forward. No need for that, the path I'm suggesting is located under arch/arm/include/asm/mach, it's not same as include . > With DMA engine conversion hopefully, we might get rid of the > header eventually, but for now not sure whether we should > go ahead and follow the splitting part. > > Thoughts ? No need for splitting anything :) The other possible location would be just include , but as we all know that will be going away, is probably better. Tony