From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: tony@atomide.com, linux-omap@vger.kernel.org,
santosh.shilimkar@ti.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/4] ARM: OMAP: Move omap_reserve() locally to mach-omap1/2
Date: Sat, 29 Sep 2012 20:39:44 +0100 [thread overview]
Message-ID: <20120929193944.GB15246@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1348839609-10456-4-git-send-email-lokeshvutla@ti.com>
On Fri, Sep 28, 2012 at 07:10:08PM +0530, Lokesh Vutla wrote:
> omap_reserve() is a stub for omap1. So creating a
> stub locally in mach-omap1. And moving the definition
> to mach-omap2.
> This helps in moving plat/omap_secure.h local to
> mach-omap2
>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> Acked-by : Santosh Shilimkar <santosh.shilimkar@ti.com>
> ---
> arch/arm/mach-omap1/common.h | 3 +++
> arch/arm/mach-omap2/common.c | 20 ++++++++++++++++++++
> arch/arm/mach-omap2/common.h | 1 +
> arch/arm/plat-omap/common.c | 17 -----------------
> arch/arm/plat-omap/include/plat/common.h | 1 -
> 5 files changed, 24 insertions(+), 18 deletions(-)
>
> diff --git a/arch/arm/mach-omap1/common.h b/arch/arm/mach-omap1/common.h
> index c2552b2..f7b01f1 100644
> --- a/arch/arm/mach-omap1/common.h
> +++ b/arch/arm/mach-omap1/common.h
> @@ -90,4 +90,7 @@ extern int ocpi_enable(void);
> static inline int ocpi_enable(void) { return 0; }
> #endif
>
> +static inline void omap_reserve(void)
> +{ }
This is the wrong approach. If OMAP1 doesn't need to do any reservation,
then OMAP1 platforms should not be calling omap_reserve() and OMAP1 should
not have this defined.
Just because OMAP2 does something one way does not mean OMAP1 needs to
copy it in every detail.
next prev parent reply other threads:[~2012-09-29 19:39 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 13:40 [PATCH 0/4] ARM: OMAP: Move plat/dma*.h,omap-secure.h headers as part of single zImage work Lokesh Vutla
2012-09-28 13:40 ` [PATCH 1/4] ARM: OMAP: DMA: Removing plat/dma-44xx.h Lokesh Vutla
2012-09-28 13:40 ` [PATCH 2/4] ARM: OMAP: DMA: Move plat/dma hearder to platform_data/dma-omap Lokesh Vutla
2012-09-28 14:55 ` Tony Lindgren
2012-09-28 15:01 ` Shilimkar, Santosh
2012-09-28 15:05 ` Tony Lindgren
2012-09-28 15:11 ` Shilimkar, Santosh
2012-09-28 15:54 ` Russell King - ARM Linux
2012-09-28 19:35 ` Jon Hunter
2012-09-29 16:57 ` Tony Lindgren
2012-10-01 8:51 ` Vutla, Lokesh
2012-09-28 13:40 ` [PATCH 3/4] ARM: OMAP: Move omap_reserve() locally to mach-omap1/2 Lokesh Vutla
2012-09-29 19:39 ` Russell King - ARM Linux [this message]
2012-09-30 8:20 ` Shilimkar, Santosh
2012-09-30 18:05 ` Tony Lindgren
2012-10-01 5:01 ` Vutla, Lokesh
2012-09-28 13:40 ` [PATCH 4/4] ARM: OMAP: Move plat/omap-secure.h locally to mach-omap2 Lokesh Vutla
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120929193944.GB15246@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=lokeshvutla@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox