From: Tony Lindgren <tony@atomide.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Marc Zyngier <marc.zyngier@arm.com>,
Dave Martin <dave.martin@linaro.org>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
Nicolas Pitre <nico@fluxnic.net>
Subject: Re: [PATCH v2 2/7] ARM: virt: allow the kernel to be entered in HYP mode
Date: Fri, 5 Oct 2012 16:23:25 -0700 [thread overview]
Message-ID: <20121005232325.GV3874@atomide.com> (raw)
In-Reply-To: <20121005230908.GC15246@n2100.arm.linux.org.uk>
* Russell King - ARM Linux <linux@arm.linux.org.uk> [121005 16:10]:
> On Fri, Oct 05, 2012 at 01:08:22PM -0700, Tony Lindgren wrote:
> > Just bisected this down in linux-next for breaking booting of
> > my omap2420 ARMv6 based n8x0..
> >
> > > --- a/arch/arm/kernel/head.S
> > > +++ b/arch/arm/kernel/head.S
> > > @@ -83,8 +83,12 @@ ENTRY(stext)
> > > THUMB( .thumb ) @ switch to Thumb now.
> > > THUMB(1: )
> > >
> > > - setmode PSR_F_BIT | PSR_I_BIT | SVC_MODE, r9 @ ensure svc mode
> > > - @ and irqs disabled
> > > +#ifdef CONFIG_ARM_VIRT_EXT
> > > + bl __hyp_stub_install
> > > +#endif
> > > + @ ensure svc mode and all interrupts masked
> > > + safe_svcmode_maskall r9
> > > +
> > > mrc p15, 0, r9, c0, c0 @ get processor id
> > > bl __lookup_processor_type @ r5=procinfo r9=cpuid
> > > movs r10, r5 @ invalid processor (r5=0)?
> >
> > ..and looks like undoing this part fixes it. Any ideas?
> >
> > I quickly tried disabling ARCH_OMAP3 and ARCH_OMAP4 so it's
> > ARMv6 but that does not help.
>
> You really should Cc me when you hit something like this. I was
> thinking about sending my tree (which contains these changes) this
> evening but if they're breaking stuff, I'd prefer to delay that
> stuff at least for a while.
Sorry was planning to cc you for sure but forgot. Got any ideas
what to try to fix this?
Tony
next prev parent reply other threads:[~2012-10-05 23:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1347036934-8519-1-git-send-email-marc.zyngier@arm.com>
[not found] ` <1347036934-8519-3-git-send-email-marc.zyngier@arm.com>
2012-10-05 20:08 ` [PATCH v2 2/7] ARM: virt: allow the kernel to be entered in HYP mode Tony Lindgren
2012-10-05 23:09 ` Russell King - ARM Linux
2012-10-05 23:23 ` Tony Lindgren [this message]
2012-10-05 23:50 ` Tony Lindgren
2012-10-06 1:32 ` Nicolas Pitre
2012-10-06 3:06 ` Tony Lindgren
2012-10-06 10:18 ` Marc Zyngier
2012-10-06 14:06 ` Nicolas Pitre
2012-10-06 14:44 ` Tony Lindgren
2012-10-06 14:47 ` Marc Zyngier
2012-10-06 14:42 ` Tony Lindgren
2012-10-06 15:32 ` Nicolas Pitre
2012-10-06 15:40 ` Tony Lindgren
2012-10-06 16:06 ` Marc Zyngier
2012-10-06 15:42 ` Russell King - ARM Linux
2012-10-06 16:00 ` Tony Lindgren
2012-10-08 11:01 ` Dave Martin
2012-10-08 11:33 ` Marc Zyngier
2012-10-08 20:36 ` Tony Lindgren
2012-10-08 11:33 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121005232325.GV3874@atomide.com \
--to=tony@atomide.com \
--cc=dave.martin@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marc.zyngier@arm.com \
--cc=nico@fluxnic.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).