From: Tony Lindgren <tony@atomide.com>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: "Russell King - ARM Linux" <linux@arm.linux.org.uk>,
linux-omap@vger.kernel.org,
"Santosh Shilimkar" <santosh.shilimkar@ti.com>,
"Cousson, Benoit" <b-cousson@ti.com>,
"Paul Walmsley" <paul@pwsan.com>, "Kevin Hilman" <khilman@ti.com>,
"Afzal Mohammed" <afzal@ti.com>,
"Péter Ujfalusi" <peter.ujfalusi@ti.com>
Subject: Re: Errors at boot time from OMAP4430SDP (and a whinge about serial stuff)
Date: Tue, 16 Oct 2012 11:26:42 -0700 [thread overview]
Message-ID: <20121016182642.GF15569@atomide.com> (raw)
In-Reply-To: <20121016181038.GC15569@atomide.com>
* Tony Lindgren <tony@atomide.com> [121016 11:12]:
> * Ohad Ben-Cohen <ohad@wizery.com> [121014 11:32]:
> > On Fri, Oct 12, 2012 at 6:24 PM, Tony Lindgren <tony@atomide.com> wrote:
> > >> Error setting wl12xx data: -38
> > ..
> > > Ohad, can you please take a look?
> >
> > Sure, -38 is -ENOSYS which is returned when the wl12xx driver isn't configured.
> >
> > This isn't an error (it's a user decision, and it shouldn't elicit any
> > error) and the patch below (also attached) should make it go away on:
> >
> > From 374f145568585c8d6a8d5e4b8b5d3e6baedd2f39 Mon Sep 17 00:00:00 2001
> > From: Ohad Ben-Cohen <ohad@wizery.com>
> > Date: Sun, 14 Oct 2012 20:16:01 +0200
> > Subject: [PATCH] ARM: OMAP: don't print any error when wl12xx isn't
> > configured
> >
> > Stop intimidating users with scary wlan error messages in case wl12xx
> > support wasn't even built.
> >
> > In addition, when wl12xx_set_platform_data() fails, don't bother
> > registering wl12xx's fixed regulator device (on the relevant
> > boards).
> >
> > While we're at it, extract the wlan init code to a dedicated function to
> > make (the relevant boards') init code look a bit nicer.
> >
> > Reported-by: Russell King <linux@arm.linux.org.uk>
> > Signed-off-by: Ohad Ben-Cohen <ohad@wizery.com>
>
> Thanks applying into omap-for-v3.7-rc1/fixes-part2.
Hmm looking at it repeats the same code over again. Can you
rather add some wl12xx_board_init() helper function to mach-omap2/devices.c
to do it? Dropping this for now.
Regards,
Tony
next prev parent reply other threads:[~2012-10-16 18:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-12 15:54 Errors at boot time from OMAP4430SDP (and a whinge about serial stuff) Russell King - ARM Linux
2012-10-12 16:24 ` Tony Lindgren
2012-10-12 16:31 ` Russell King - ARM Linux
2012-10-12 16:34 ` Benoit Cousson
2012-10-12 16:56 ` Tony Lindgren
2012-10-12 18:47 ` Kevin Hilman
2012-10-14 18:30 ` Ohad Ben-Cohen
2012-10-16 18:10 ` Tony Lindgren
2012-10-16 18:26 ` Tony Lindgren [this message]
2012-10-17 9:10 ` Ohad Ben-Cohen
2012-10-17 12:43 ` Igor Grinberg
2012-10-18 16:58 ` Ohad Ben-Cohen
2012-10-19 17:07 ` Tony Lindgren
2012-10-21 14:54 ` Ohad Ben-Cohen
2012-10-23 7:37 ` Igor Grinberg
2012-10-23 7:51 ` Ohad Ben-Cohen
2012-10-23 9:46 ` Igor Grinberg
2012-10-24 1:54 ` Tony Lindgren
2012-10-24 11:15 ` Ohad Ben-Cohen
2012-10-25 19:03 ` Tony Lindgren
2012-10-15 5:54 ` Mohammed, Afzal
2012-10-16 18:12 ` Tony Lindgren
2012-10-16 19:24 ` Benoit Cousson
2012-10-16 19:53 ` Tony Lindgren
2012-10-15 7:37 ` Péter Ujfalusi
2012-10-23 10:10 ` Russell King - ARM Linux
2012-10-25 1:09 ` Tony Lindgren
2012-10-25 16:05 ` Balaji T K
2012-10-25 17:24 ` Kevin Hilman
2012-10-25 17:38 ` Kevin Hilman
2012-10-25 17:46 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121016182642.GF15569@atomide.com \
--to=tony@atomide.com \
--cc=afzal@ti.com \
--cc=b-cousson@ti.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ohad@wizery.com \
--cc=paul@pwsan.com \
--cc=peter.ujfalusi@ti.com \
--cc=santosh.shilimkar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).