From: Nishanth Menon <nm@ti.com>
To: Jean Pihet <jean.pihet@newoldbits.com>
Cc: l-o <linux-omap@vger.kernel.org>, Kevin Hilman <khilman@ti.com>,
Jean Pihet <j-pihet@ti.com>, J Keerthy <j-keerthy@ti.com>
Subject: Re: [RFC PATCH 4/6] ARM: OMAP: SmartReflex: provide SoC integration API for VP
Date: Thu, 25 Oct 2012 07:55:11 -0500 [thread overview]
Message-ID: <20121025125510.GA22894@kahuna> (raw)
In-Reply-To: <CAORVsuWo0Gd1aBqtpJ7+S663a380kbM7jDbEaq37DGfCmEdFgA@mail.gmail.com>
On 10:27-20121025, Jean Pihet wrote:
> On Tue, Oct 23, 2012 at 11:43 PM, Nishanth Menon <nm@ti.com> wrote:
[..]
> > static int sr_class3_disable(struct omap_sr *sr, int is_volt_reset)
> > {
> > + if (!sr->soc_ops.vp_enable) {
> This should be ' if (!sr->soc_ops.vp_disbable) {'.
Argh.. yes. thanks for catching it. I will wait for any further comments
prior to reposting with the fix.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2012-10-25 12:55 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 21:43 [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs Nishanth Menon
2012-10-23 21:43 ` [RFC PATCH 1/6] PM / AVS / OMAP: move Kconfig definition of smartreflex to avs directory Nishanth Menon
2012-10-23 21:43 ` [RFC PATCH 2/6] ARM: OMAP: voltage: remove duplicate header definitions Nishanth Menon
2012-10-23 21:43 ` [RFC PATCH 3/6] ARM: OMAP: voltage: move voltdm_reset to platform_data header Nishanth Menon
2012-10-23 21:43 ` [RFC PATCH 4/6] ARM: OMAP: SmartReflex: provide SoC integration API for VP Nishanth Menon
2012-10-25 8:27 ` Jean Pihet
2012-10-25 12:55 ` Nishanth Menon [this message]
2012-11-03 13:10 ` Kevin Hilman
2012-10-23 21:44 ` [RFC PATCH 5/6] ARM: OMAP: SmartReflex: use pr_warn instead of pr_warning Nishanth Menon
2012-10-23 21:44 ` [RFC PATCH 6/6] PM / AVS / OMAP: move Smartreflex-class3 driver to power/avs Nishanth Menon
2012-10-25 8:21 ` [RFC PATCH 0/6] ARM: OMAP3+: move smartreflex-class3.c to drivers/power/avs Jean Pihet
2012-11-03 13:14 ` Kevin Hilman
2012-11-03 14:44 ` Jean Pihet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20121025125510.GA22894@kahuna \
--to=nm@ti.com \
--cc=j-keerthy@ti.com \
--cc=j-pihet@ti.com \
--cc=jean.pihet@newoldbits.com \
--cc=khilman@ti.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).