[PATCH 1/1] mmc: omap_hsmmc: remove warning message for debounce clock

[PATCH 1/1] mmc: omap_hsmmc: remove warning message for debounce clock

[Balaji T K]

MMC debounce clock is applicable only for omap2430, warning message gets
printed when enable fails for debounce clock. Remove the get debounce clock
failure message as it is noisy for other platforms.

Signed-off-by: Balaji T K <balajitk@ti.com>
Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
---
 drivers/mmc/host/omap_hsmmc.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
index 54bfd0c..9a4ef4d 100644
--- a/drivers/mmc/host/omap_hsmmc.c
+++ b/drivers/mmc/host/omap_hsmmc.c
@@ -1816,7 +1816,6 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev)
 	 * MMC can still work without debounce clock.
 	 */
 	if (IS_ERR(host->dbclk)) {
-		dev_warn(mmc_dev(host->mmc), "Failed to get debounce clk\n");
 		host->dbclk = NULL;
 	} else if (clk_prepare_enable(host->dbclk) != 0) {
 		dev_warn(mmc_dev(host->mmc), "Failed to enable debounce clk\n");
-- 
1.7.5.4

Re: [PATCH 1/1] mmc: omap_hsmmc: remove warning message for debounce clock

[Tony Lindgren]

* Balaji T K <balajitk@ti.com> [121025 09:00]:
> MMC debounce clock is applicable only for omap2430, warning message gets
> printed when enable fails for debounce clock. Remove the get debounce clock
> failure message as it is noisy for other platforms.
> 
> Signed-off-by: Balaji T K <balajitk@ti.com>
> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>

This would be good to get in during the -rc cycle if possible to remove
the bogus warnings on non-2430 omaps. But since it's been there for a
long time, we can wait too if needed.

Acked-by: Tony Lindgren <tony@atomide.com>

> ---
>  drivers/mmc/host/omap_hsmmc.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mmc/host/omap_hsmmc.c b/drivers/mmc/host/omap_hsmmc.c
> index 54bfd0c..9a4ef4d 100644
> --- a/drivers/mmc/host/omap_hsmmc.c
> +++ b/drivers/mmc/host/omap_hsmmc.c
> @@ -1816,7 +1816,6 @@ static int __devinit omap_hsmmc_probe(struct platform_device *pdev)
>  	 * MMC can still work without debounce clock.
>  	 */
>  	if (IS_ERR(host->dbclk)) {
> -		dev_warn(mmc_dev(host->mmc), "Failed to get debounce clk\n");
>  		host->dbclk = NULL;
>  	} else if (clk_prepare_enable(host->dbclk) != 0) {
>  		dev_warn(mmc_dev(host->mmc), "Failed to enable debounce clk\n");
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] mmc: omap_hsmmc: remove warning message for debounce clock

[Chris Ball]

Hi,

On Thu, Oct 25 2012, Tony Lindgren wrote:
> * Balaji T K <balajitk@ti.com> [121025 09:00]:
>> MMC debounce clock is applicable only for omap2430, warning message gets
>> printed when enable fails for debounce clock. Remove the get debounce clock
>> failure message as it is noisy for other platforms.
>> 
>> Signed-off-by: Balaji T K <balajitk@ti.com>
>> Reported-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> This would be good to get in during the -rc cycle if possible to remove
> the bogus warnings on non-2430 omaps. But since it's been there for a
> long time, we can wait too if needed.
>
> Acked-by: Tony Lindgren <tony@atomide.com>

Thanks; pushed to mmc-next, I'll send it for 3.7.

- Chris.
-- 
Chris Ball   <cjb@laptop.org>   <http://printf.net/>
One Laptop Per Child