linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christopher Harvey <charvey@matrox.com>
To: linux-omap@vger.kernel.org
Cc: linux-mtd@lists.infradead.org
Subject: [PATCH v2] mtd: omap: nand: Remove 0xFF's that prefixed 16bit NAND commands
Date: Fri, 26 Oct 2012 15:36:43 -0400	[thread overview]
Message-ID: <20121026193643.GA21510@harvey-pc.matrox.com> (raw)
In-Reply-To: <20121026193410.GA21474@harvey-pc.matrox.com>

In 16bit NAND mode the GPMC would send the command 0xNN as 0xFFNN
instead of 0x00NN on the bus. The 0xFFs were actually uninitialized
bits that were left unset in the GPMC command output register. The
reason they weren't initialized in 16bit mode is that if the same code
that writes to this register was used in 8bit mode then 2 commands
would be output in 8bit mode. One for the low byte, and an extra 0x0
command for the high byte. This commit uses writew if we're using
16bit NAND.

Most chips seem fine with the extra 0xFFs, but the ONFI spec says
otherwise.

Signed-off-by: Christopher Harvey <charvey@matrox.com>
---
 drivers/mtd/nand/omap2.c |   14 +++++++++-----
 1 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 5b31386..ae6738f 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -225,16 +225,20 @@ static void omap_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl)
 {
 	struct omap_nand_info *info = container_of(mtd,
 					struct omap_nand_info, mtd);
+	void __iomem *reg;
 
 	if (cmd != NAND_CMD_NONE) {
 		if (ctrl & NAND_CLE)
-			writeb(cmd, info->reg.gpmc_nand_command);
-
+			reg = info->reg.gpmc_nand_command;
 		else if (ctrl & NAND_ALE)
-			writeb(cmd, info->reg.gpmc_nand_address);
-
+			reg = info->reg.gpmc_nand_address;
 		else /* NAND_NCE */
-			writeb(cmd, info->reg.gpmc_nand_data);
+			reg = info->reg.gpmc_nand_data;
+
+		if (info->nand.options & NAND_BUSWIDTH_16)
+			writew(cmd, reg);
+		else
+			writeb(cmd, reg);
 	}
 }
 
-- 
1.7.8.6

  reply	other threads:[~2012-10-26 19:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-26 19:34 [PATCH v2] 16 bit NAND fix, request for testers Christopher Harvey
2012-10-26 19:36 ` Christopher Harvey [this message]
2012-10-29 13:49   ` [PATCH v2] mtd: omap: nand: Remove 0xFF's that prefixed 16bit NAND commands Ivan Djelic
2012-10-29 17:04     ` Christopher Harvey
2012-10-29 19:51 ` [PATCH v3] mtd: omap: nand: Remove 0xFF's that prefixed 16bit NAND addresses Christopher Harvey
2012-11-15 11:02   ` Artem Bityutskiy
2012-11-15 14:48     ` Christopher Harvey
2012-11-15 15:18       ` Artem Bityutskiy
2012-11-15 15:38         ` Christopher Harvey
2012-11-15 16:29         ` Ivan Djelic
     [not found] <cover.1351278594.git.charvey@matrox.com>
2012-10-26 19:35 ` [PATCH v2] mtd: omap: nand: Remove 0xFF's that prefixed 16bit NAND commands Christopher Harvey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121026193643.GA21510@harvey-pc.matrox.com \
    --to=charvey@matrox.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).