linux-omap.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jean Delvare <khali@linux-fr.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
	Felipe Balbi <balbi@ti.com>, Benoit Cousson <b-cousson@ti.com>,
	Tony Lindgren <tony@atomide.com>,
	w.sang@pengutronix.de,
	Santosh Shilimkar <santosh.shilimkar@ti.com>,
	linux-i2c@vger.kernel.org, ben-linux@fluff.org,
	Linux OMAP Mailing List <linux-omap@vger.kernel.org>,
	Shubhrajyoti Datta <shubhrajyoti@ti.com>,
	Linux ARM Kernel Mailing List
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 7/8] i2c: add 'transferred' field to struct i2c_msg
Date: Sat, 27 Oct 2012 18:02:35 +0100	[thread overview]
Message-ID: <20121027170235.GA24388@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20121027164013.GV2616@ZenIV.linux.org.uk>

On Sat, Oct 27, 2012 at 05:40:13PM +0100, Al Viro wrote:

> You are wrong.  Assumption that pointers are aligned to 32bit boundary
> is simply not true.  In particular, on m68k alignment is 16bit, i.e. there
> struct foo {
> 	char x;
> 	void *p;
> }; will have 1 byte occupied by x, followed by 1-byte gap, followed by 4 bytes
> occupied by p.
> 
> Note, BTW, that m68k includes things like coldfire, etc. and I wouldn't be
> surprised by e.g. coldfire-based SoC with i2c on it.

BTW, that's easily verified - take a cross-compiler and do this:
; cat >a.c <<'EOF'
struct { char x; void *y; } v;
int z = (char *)&v.y - (char *)&v;
EOF
; m68k-linux-gnu-gcc -S a.c
; grep -A1 'z:' a.s
z:
        .long   2
;
and watch what it puts into z.  gcc is very liberal about what it considers
a constant expression, so it allows that sort of expressions as initializers
for global variables.  Not a portable C, but convenient for experiments like
that; just grab a cross-toolchain and feed it testcases of that kind...

  reply	other threads:[~2012-10-27 17:02 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-22  9:46 [PATCH 0/8] I2C patches for v3.8 merge window Felipe Balbi
2012-10-22  9:46 ` [PATCH 1/8] i2c: omap: no need to access platform_device Felipe Balbi
2012-10-22  9:46 ` [PATCH 2/8] i2c: omap: reorder exit path of omap_i2c_xfer_msg() Felipe Balbi
2012-10-25 11:40   ` Shubhrajyoti Datta
     [not found]     ` <CAM=Q2cvUeLbS20HScrGTOcraSUrCzhzCi8MQLxd9MOb_7ZFFYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-10-25 12:01       ` Felipe Balbi
2012-10-22  9:46 ` [PATCH 5/8] i2c: omap: introduce and use OMAP_I2C_IP_VERSION_3 Felipe Balbi
     [not found]   ` <1350899218-13624-6-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-22 12:27     ` Benoit Cousson
2012-10-22 12:28       ` Felipe Balbi
     [not found]         ` <20121022122853.GW14033-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-22 13:05           ` Benoit Cousson
     [not found]             ` <50854490.4060306-l0cyMroinI0@public.gmane.org>
2012-10-22 13:09               ` Felipe Balbi
2012-10-22 13:18     ` [PATCH v2 5/8] i2c: omap: in case of VERSION_2 read IRQSTATUS_RAW but write to IRQSTATUS Felipe Balbi
     [not found] ` <1350899218-13624-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-22  9:46   ` [PATCH 3/8] i2c: omap: fix error checking Felipe Balbi
     [not found]     ` <1350899218-13624-4-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-24 14:41       ` Michael Trimarchi
     [not found]         ` <5087FE07.6090504-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2012-10-25 10:10           ` Felipe Balbi
     [not found]             ` <20121025101010.GC21217-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-25 10:33               ` Michael Trimarchi
     [not found]                 ` <5089156E.7020701-dyjBcgdgk7Pe9wHmmfpqLFaTQe2KTcn/@public.gmane.org>
2012-10-25 10:48                   ` Felipe Balbi
2012-10-22  9:46   ` [PATCH 4/8] i2c: omap: also complete() when stat becomes zero Felipe Balbi
2012-10-22  9:46   ` [PATCH 6/8] i2c: omap: wait for transfer completion before sending STP bit Felipe Balbi
2012-10-22  9:46   ` [PATCH 7/8] i2c: add 'transferred' field to struct i2c_msg Felipe Balbi
2012-10-25 12:57     ` Jean Delvare
     [not found]       ` <20121025145748.760c218b-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-25 13:14         ` Russell King - ARM Linux
2012-10-25 13:42           ` Jean Delvare
     [not found]             ` <20121025154202.41f3cbba-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-25 13:46               ` Russell King - ARM Linux
     [not found]                 ` <20121025134609.GH28061-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-10-25 13:56                   ` Jean Delvare
     [not found]                     ` <20121025155633.609c5554-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-25 14:18                       ` Russell King - ARM Linux
     [not found]                         ` <20121025141800.GI28061-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2012-10-27 14:32                           ` Jean Delvare
     [not found]                             ` <20121027163224.67d57aef-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2012-10-27 16:40                               ` Al Viro
2012-10-27 17:02                                 ` Al Viro [this message]
     [not found]                                   ` <20121027170235.GA24388-3bDd1+5oDREiFSDQTTA3OLVCufUGDwFn@public.gmane.org>
2012-10-27 17:10                                     ` Al Viro
2012-10-27 19:03                                       ` Jean Delvare
2012-10-27 17:25                               ` Russell King - ARM Linux
2012-10-22  9:46   ` [PATCH 8/8] i2c: omap: implement handling for 'transferred' bytes Felipe Balbi
2012-10-22 13:30 ` [PATCH 0/8] I2C patches for v3.8 merge window Felipe Balbi
     [not found]   ` <20121022133023.GC14033-S8G//mZuvNWo5Im9Ml3/Zg@public.gmane.org>
2012-10-22 14:06     ` Shubhrajyoti Datta
2012-10-22 14:06       ` Felipe Balbi
2012-10-22 15:02         ` Shubhrajyoti
     [not found]       ` <CAM=Q2ctS3hxngk5efcvScAdv-2GtH2pHRZoxRhRTiOWmQA-AXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-14 16:58         ` Wolfram Sang
2012-10-25 12:25 ` [PATCH v2 0/7] " Felipe Balbi
     [not found]   ` <1351167915-15079-1-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-25 12:25     ` [PATCH v2 1/7] i2c: omap: no need to access platform_device Felipe Balbi
     [not found]       ` <1351167915-15079-2-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-25 12:41         ` Santosh Shilimkar
2012-10-25 12:25     ` [PATCH v2 2/7] i2c: omap: reorder exit path of omap_i2c_xfer_msg() Felipe Balbi
     [not found]       ` <1351167915-15079-3-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-25 12:42         ` Santosh Shilimkar
     [not found]           ` <50893398.6070004-l0cyMroinI0@public.gmane.org>
2012-10-25 12:40             ` Felipe Balbi
2012-10-25 12:53           ` Lothar Waßmann
2012-10-25 12:25     ` [PATCH v2 3/7] i2c: omap: also complete() when stat becomes zero Felipe Balbi
     [not found]       ` <1351167915-15079-4-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-25 12:43         ` Santosh Shilimkar
     [not found]           ` <508933E4.7070608-l0cyMroinI0@public.gmane.org>
2012-10-25 12:39             ` Felipe Balbi
2012-10-25 12:25     ` [PATCH v2 4/7] i2c: omap: in case of VERSION_2 read IRQSTATUS_RAW but write to IRQSTATUS Felipe Balbi
     [not found]       ` <1351167915-15079-5-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-25 12:53         ` Santosh Shilimkar
     [not found]           ` <50893665.60604-l0cyMroinI0@public.gmane.org>
2012-10-25 12:52             ` Felipe Balbi
2012-10-25 13:06               ` Santosh Shilimkar
2012-10-25 12:25     ` [PATCH v2 5/7] i2c: omap: wait for transfer completion before sending STP bit Felipe Balbi
2012-10-25 12:32       ` Felipe Balbi
2012-10-25 12:34       ` [PATCH v3 " Felipe Balbi
     [not found]       ` <1351167915-15079-6-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-25 13:01         ` [PATCH v2 " Santosh Shilimkar
2012-10-25 14:15           ` Felipe Balbi
2012-10-25 12:25     ` [PATCH v2 7/7] i2c: omap: implement handling for 'transferred' bytes Felipe Balbi
     [not found]       ` <1351167915-15079-8-git-send-email-balbi-l0cyMroinI0@public.gmane.org>
2012-10-27 18:55         ` Paul Walmsley
2012-11-05  8:10     ` [PATCH v2 0/7] I2C patches for v3.8 merge window Felipe Balbi
2012-10-25 12:25   ` [PATCH v2 6/7] i2c: add 'transferred' field to struct i2c_msg Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20121027170235.GA24388@ZenIV.linux.org.uk \
    --to=viro@zeniv.linux.org.uk \
    --cc=b-cousson@ti.com \
    --cc=balbi@ti.com \
    --cc=ben-linux@fluff.org \
    --cc=khali@linux-fr.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=santosh.shilimkar@ti.com \
    --cc=shubhrajyoti@ti.com \
    --cc=tony@atomide.com \
    --cc=w.sang@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).